Adium

Ticket #9989 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

Chat log viewer wrongly parses non-emoticon text as emoticons

Reported by: pi++ Assigned to: earthmkii
Priority: normal Milestone: SVN issues
Component: Logging Version: 1.3svn
Severity: regression Keywords: log chat viewer emoticons
Cc: Patch: None
Pending: 0

Description

I've noticed that with svn-revision 23835, when opening the Chat log viewer:
1) The first timestamp, if it contains text that is an emoticon equivalent (things like :1, :0, :2), is shown with an emoticon inside it. That seems to happen only for the minutes (hh:Mm:ss), never for the seconds.

2) Sometimes emoticons are displayed in timestamps following status messages like "State changed to 'offline' (hh:mm:ss)". It happens only sometimes, not always... I can't understand the pattern behind it.

3) What I think is a default ICQ emoticon ( O:-) ) is rendered as a sequence of two emoticons ( :O :-) ) when placed like this ( (hh:mm:ss) NickName:O:-) )

See you,
Pietro

Attachments

Caso 1 - Orario di inizio.png (16.2 kB) - added by pi++ on 06/08/2008 07:51:47 AM.
Case 1 - First timestamp
Caso 2 - Messaggio di stato.png (8.9 kB) - added by pi++ on 06/08/2008 07:53:16 AM.
Case 2 - State change message
Caso 3a - Emoticon ICQ visualizzata.png (3.6 kB) - added by pi++ on 06/08/2008 07:54:38 AM.
Case 3a - ICQ Emoticon
Caso 3b - Emoticon ICQ testo.png (3.1 kB) - added by pi++ on 06/08/2008 07:55:42 AM.
Case 3b - ICQ Emoticon (as text)

Change History

06/08/2008 07:51:47 AM changed by pi++

  • attachment Caso 1 - Orario di inizio.png added.

Case 1 - First timestamp

06/08/2008 07:53:16 AM changed by pi++

  • attachment Caso 2 - Messaggio di stato.png added.

Case 2 - State change message

06/08/2008 07:54:38 AM changed by pi++

  • attachment Caso 3a - Emoticon ICQ visualizzata.png added.

Case 3a - ICQ Emoticon

06/08/2008 07:55:42 AM changed by pi++

  • attachment Caso 3b - Emoticon ICQ testo.png added.

Case 3b - ICQ Emoticon (as text)

06/08/2008 08:42:52 AM changed by jas8522

  • owner changed from nobody to earthmkii.
  • severity changed from normal to minor.
  • milestone set to Adium X 1.3.x.

06/08/2008 08:46:18 AM changed by Robby

  • severity changed from minor to regression.
  • milestone changed from Adium X 1.3.x to Adium X 1.3.

Shouldn't this be considered a regression?

06/08/2008 01:57:44 PM changed by zacw

(In [23848]) Making the Default emoticon set a bit more conservative. Refs #9989.

06/08/2008 01:58:36 PM changed by zacw

(In [23849]) ':l' too. Refs #9989.

06/08/2008 02:43:46 PM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [23850]) Decode messages separately, and filter them on their own, rather than decoding and filtering the entire displayed chat log. This lets us not emoticonify and otherwise modify timestamps, sender names, and statuses. Fixes #9989

06/08/2008 05:58:45 PM changed by Robby

  • milestone changed from Adium X 1.3 to SVN issues.