Adium

Ticket #9970 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

Can't open a message window for offline msn contacts

Reported by: Dimmuxx Assigned to: evands
Priority: normal Milestone: Adium X 1.3
Component: MSN Version: 1.3svn
Severity: regression Keywords: msn offline chat
Cc: evands Patch: None
Pending: 0

Description

I'm currently testing msnp15 with the new token patch in revision 23800 of Adium 1.3svn and I noticed today that I can't open a message window for offline msn contacts. It's no problem to send offline messages to contacts that I already have opened a window for while they were online. I'm pretty sure this is by design since msnp9 doesn't support offline messages and that I'm able to open a message window for offline icq contacts. I have tried looking around in the source code for where it's defined but since I'm not familiar with Adium's source code I haven't been able to find it.

I would appreciate it if anybody could point me in the right direction or perhaps do something similar to the define NEW_MSN in ESPurpleMSNAccount.h but for offline msn contacts.

Change History

06/05/2008 10:50:35 AM changed by zacw

Do you have any console output when you try to open the message window?

06/05/2008 10:53:52 AM changed by Dimmuxx

16:52:38: -preferredAccountForSendingContentType:toContact:includeOffline:: Could not find a good choice to talk to <AIListContact:918d880 MSN.********@hotmail.com>; will return first available account 16:52:38: Warning: -[AIChatController chatWithContact:(null)] got a nil targetContact.

(follow-up: ↓ 4 ) 06/05/2008 11:02:58 AM changed by zacw

Is your account offline at the time you're trying to do this?

(in reply to: ↑ 3 ) 06/05/2008 11:20:08 AM changed by Dimmuxx

Replying to zacw:

Is your account offline at the time you're trying to do this?

Nope, it would be pretty hard to send an OIM if I was offline.

06/07/2008 09:47:08 AM changed by jas8522

  • cc set to evands.
  • component changed from Adium Core to MSN.
  • milestone set to Needs dev review.

Evan: seems like you would be the best to ask about this ;)

06/07/2008 08:55:54 PM changed by Dimmuxx

It seems to work in revision 23184 according to one user in the forum who uses the build in this thread http://forums.cocoaforge.com/viewtopic.php?f=10&t=17105.

06/09/2008 09:11:32 PM changed by jas8522

  • severity changed from normal to regression.
  • milestone changed from Needs dev review to Adium X 1.3.

Setting to 1.3 as this sounds like a regression

06/11/2008 08:04:33 PM changed by evands

  • owner changed from nobody to evands.
  • status changed from new to assigned.

There are two problems at work here:

  1. The MSNp15 code in libpurple has not been properly updated to know that it supports offline messaging. This makes Adium think that an MSN account can not actually message an offline MSN contact.
  2. A bug in updated preferred account handling made it so that in this situation and similar situations we did nothing rather than giving an account which can't message the contact (and therefore allowing a message window to open... which if the account doesn't support offline messaging would at least allow prompting to Send Later).

06/11/2008 08:06:34 PM changed by evands

The fix to come will fix (2) above; (1) needs to be fixed in libpurple.

06/11/2008 08:08:56 PM changed by evands

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [23929]) Fixed and simplified determination of preferred accounts for messaging contacts. Removed a couple public methods which shouldn't exist in the process. Fixes opening message windows for offline contacts on accounts which don't support offline messaging, among other problems. Fixes #9970