Adium

Ticket #9893 (closed defect: fixed)

Opened 3 months ago

Last modified 1 month ago

Contact inspector events line-height does not adjust to the contained text when opening window/switching panes

Reported by: TheDodger Assigned to: zacw
Priority: low Milestone: SVN issues
Component: Contact Inspector Version: 1.3svn
Severity: minor Keywords: contact inspector events pane
Cc: Patch: None
Pending: 0

Description

In the new contact inspector the display of events is sometimes messed up. The lines for each event seem not to be high enough.

See screenshot.

Attachments

Events pane.png (62.9 kB) - added by TheDodger on 05/25/2008 06:41:55 AM.

Change History

05/25/2008 06:41:55 AM changed by TheDodger

  • attachment Events pane.png added.

05/25/2008 06:46:43 AM changed by TheDodger

Oh, forgot to mention: this is 10.5.2...

05/25/2008 07:01:38 AM changed by Robby

  • milestone set to Adium X 1.3.

You wrote "sometimes", could you find some steps to reproduce?
This might be related to #9886.

05/25/2008 08:23:46 AM changed by TheDodger

Haven't been able to reproduce it since, the first time it was not only 'Contact invites you to a group chat' but also 'Message received (Background Chat)'. Oddly I've got no screenshot of that occurrence.

It seems this has something to do with the event boxes/lines not resizing dynamically. If you resize the events pane the text only gets un-wrapped, but the line doesn't change its height.

05/25/2008 08:50:34 AM changed by jas8522

  • priority changed from normal to low.
  • severity changed from normal to minor.

Indeed. Any event that starts out wrapped when the window opens takes up the height required for two lines of text (as it should). When the window is enlarged such that the text is no longer wrapped, the events remain the enlarged height, when they should go back to being the default one-line height.

It also appears that, when you shrink the window such that the text needs to wrap for events that didn't need to wrap before, it may cut wrapped lines off, however I couldn't reproduce this because the pane opened at it's min-width so I couldn't shrink it anymore.

05/25/2008 08:51:40 AM changed by jas8522

  • summary changed from Contact inspector events pane display messed up to Contact inspector events line-height does not adjust to the contained text when resizing window.

05/25/2008 03:49:34 PM changed by TheDodger

Now that #9889 is done, its obvious that the line height is either saved or hard coded. If the Events pane is properly sized so that no text needs to be wrapped the lines are sized for two lines of text when opening the inspector.

(follow-up: ↓ 9 ) 05/25/2008 03:59:38 PM changed by zacw

  • status changed from new to closed.
  • resolution set to fixed.

(In [23638]) Recalculate the height of the contact events inspector when the columns change size (fixes #9893), remove the selection ring around the events view, and fixes the inspector seizuring when resizing.

05/25/2008 04:18:14 PM changed by Robby

  • milestone changed from Adium X 1.3 to SVN issues.

(in reply to: ↑ 7 ) 05/31/2008 07:29:32 AM changed by TheDodger

When manually resizing the inspector this is fixed, but when switching to the pane: old behavior.

Calling the function that recalculates the row height when switching to the pane might fix this.

05/31/2008 11:56:03 AM changed by Robby

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone changed from SVN issues to Adium X 1.3.

06/08/2008 03:00:27 PM changed by jas8522

  • owner changed from eharris to zacw.
  • status changed from reopened to new.

06/09/2008 10:14:47 AM changed by TheDodger

Eventually the summary should be changed too, I suggest:

Contact inspector events line-height does not adjust to the contained text when opening window/switching panes

07/01/2008 09:47:57 AM changed by evands

  • summary changed from Contact inspector events line-height does not adjust to the contained text when resizing window to Contact inspector events line-height does not adjust to the contained text when opening window/switching panes.

07/01/2008 10:08:45 AM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [24141]) On 10.4, force a full reload instead of just noting that row height has changed. Although this method was introduced in 10.4, it works poorly at best there, whereas it seems to work reliably in 10.5. Fixes #9893. Fixes #10020. Fixes #9886.

07/15/2008 09:28:54 PM changed by Robby

  • milestone changed from Adium X 1.3 to SVN issues.