Adium

Ticket #9795 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Linkification of enclosed URIs with trailing punctuation is incorrect

Reported by: earthmkii Assigned to: earthmkii
Priority: normal Milestone: Adium X 1.3
Component: Message View Version: 1.2.5
Severity: normal Keywords: url uri hyperlink linkification
Cc: Patch: None
Pending: 0

Description

URIs with tailing punctuation are truncated when enclosed.

ex: 

<http://en.wikipedia.org/wiki/Safari_(web_browser)>

The result should be: <http://en.wikipedia.org/wiki/Safari_(web_browser)>, however only <http://en.wikipedia.org/wiki/Safari_(web_browser)> is linkified.

Change History

05/06/2008 10:54:33 AM changed by earthmkii

  • status changed from new to assigned.

05/06/2008 11:12:49 AM changed by jas8522

  • milestone set to Adium X 1.3.x.

Setting to the same milestone as it's sister ticket ... though if you have a patch ready before 1.3 is released then it'll likely get included in that :)

05/08/2008 12:51:32 AM changed by earthmkii

Just a note: this also affects URI's based on IPv6 addresses. Since they're required to be enclosed in brackets, -[SHHyperlinkScanner nextURLFromString:] removes the closing bracket from the matching set, forcing the URI to be invalid.

05/08/2008 03:17:55 PM changed by sholt

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [23358]) Make sure enclosed parts of URLs are linked if they are on an edge and are non-nested (ex: <http://example.com/foo_(bar)>). Fixes #9795.

05/08/2008 04:12:37 PM changed by Catfish_Man

  • milestone changed from Adium X 1.3.x to Adium X 1.3.