Adium

Ticket #9706 (closed defect: fixed)

Opened 4 months ago

Last modified 2 months ago

Camino 1.6 broke our "insert link to active page"

Reported by: darkxsun Assigned to: nobody
Priority: normal Milestone: Adium X 1.2.5
Component: Adium Core Version: 1.3svn
Severity: normal Keywords: link active page camino
Cc: Patch: Accepted
Pending: 0

Description

Apparently Camino changed a lot of things about its AppleScript syntax, including a few changes that killed our "insert like to active page" button.

A patch is attached, but it can't show the binary of the script, so I'm attaching the script also.

-Bill.

Attachments

camino16Link.diff (491 bytes) - added by darkxsun on 04/24/2008 05:17:21 PM.
patch for Camino 1.6, but probably useless (file is binary script)
Safari.scpt (18.2 kB) - added by darkxsun on 04/24/2008 05:17:55 PM.
The script in question

Change History

04/24/2008 05:17:21 PM changed by darkxsun

  • attachment camino16Link.diff added.

patch for Camino 1.6, but probably useless (file is binary script)

04/24/2008 05:17:55 PM changed by darkxsun

  • attachment Safari.scpt added.

The script in question

04/24/2008 08:14:44 PM changed by jas8522

  • milestone set to Adium X 1.3.

04/25/2008 04:09:10 PM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [23218]) Patch from darkxsun to fix Camino 1.6 support in the insert link to active page script. Thanks :) Fixes #9706

(follow-up: ↓ 5 ) 04/25/2008 04:10:21 PM changed by evands

(In [23219]) Merged [23218]: Patch from darkxsun to fix Camino 1.6 support in the insert link to active page script. Thanks :) Fixes #9706

04/25/2008 05:05:44 PM changed by evands

  • milestone changed from Adium X 1.3 to Adium X 1.2.5.

(in reply to: ↑ 3 ) 04/25/2008 05:24:24 PM changed by darkxsun

Replying to evands:

(In [23219]) Merged [23218]: Patch from darkxsun to fix Camino 1.6 support in the insert link to active page script. Thanks :) Fixes #9706

Wow... my first contribution (however minor) to a large-scale software project...

Being a CS student is paying off? ;-)

-Bill

04/25/2008 06:13:36 PM changed by evands

Congrats! Here's to many more :)

07/12/2008 07:12:31 AM changed by Robby

  • patch_status changed from Needs Dev Review to Accepted.