Adium

Ticket #9511 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

Crash when selecting "Undo Typing" or "Redo Typing" after closing a conversation tab

Reported by: 4ndy Assigned to: evands
Priority: normal Milestone: Adium X 1.2.4
Component: Adium UI Version: 1.2.3
Severity: normal Keywords: crash undo redo tab
Cc: Patch: None
Pending: 0

Description

After typing text into a conversation tab, if the tab is then closed, the "Undo Typing" option (or "Redo Typing" if "Undo Typing" action has been performed) is still available. If selected, or if the hotkey (command-z) is used, Adium will crash.

Note: The"Undo" option is not available if the last tab (and therefore the window) has been closed.

Using Adium 1.2.3, OS X 10.4.11, AOL Instant Messenger account.

Attachments

Adium.crash.log (93.1 kB) - added by 4ndy on 03/21/2008 06:10:27 PM.

Change History

03/21/2008 06:10:27 PM changed by 4ndy

  • attachment Adium.crash.log added.

03/21/2008 06:23:52 PM changed by Robby

  • milestone set to Adium X 1.2.4.

I can reproduce this in 1.2.3.

03/21/2008 06:25:16 PM changed by Robby

and in 1.3svn, also.

03/21/2008 08:54:11 PM changed by jas8522

  • milestone changed from Adium X 1.2.4 to Adium X 1.2.5.

We've got enough for 1.2.4 already, and this is not a regression - it's been around for a while, so no need to hold up an imminent release for it.

03/21/2008 10:32:53 PM changed by evands

  • owner changed from nobody to evands.
  • status changed from new to assigned.
  • milestone changed from Adium X 1.2.5 to Adium X 1.2.4.

Yup, but it offended my tired sensibilities ;)

03/21/2008 10:33:44 PM changed by evands

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [22966]) Each message view controller now provides a unique undo manager to its message entry text view. If we don't do this, we end up with a single undo manager for the whole window per the documentation on the undo manager hierarchy.

This fixes a number of obscure undo/redo bugs in the message window, including crashes after closing a tab and invoking undo/redo (fixes #9511) and undo/redo working across multiple tabs (only one of which is visible) which was just weird.

03/21/2008 10:34:22 PM changed by evands

(In [22967]) Merged [22966]: Each message view controller now provides a unique undo manager to its message entry text view. If we don't do this, we end up with a single undo manager for the whole window per the documentation on the undo manager hierarchy.

This fixes a number of obscure undo/redo bugs in the message window, including crashes after closing a tab and invoking undo/redo (fixes #9511) and undo/redo working across multiple tabs (only one of which is visible) which was just weird.