Adium

Ticket #9341 (closed defect: fixed)

Opened 6 months ago

Last modified 6 months ago

Adium ignores color opacity change for the contact list

Reported by: wwwluckyro Assigned to: boredzo
Priority: normal Milestone: Adium X 1.2.4
Component: Adium UI Version:
Severity: normal Keywords:
Cc: Patch: None
Pending: 0

Description

Adium ignores the opacity of the backgroud color of the contact list window.

To reproduce: Go to preferences > Appearance > Customize Color Theme > click Background color box and try to change opacity from the Colors window. It doesn't work.

See emage attached for an example. Opacity is set to 3%, but it still appears as 100% opaque.

Attachments

example.png (291.5 kB) - added by wwwluckyro on 02/29/2008 06:57:48 AM.
opacity slider is ignored

Change History

02/29/2008 06:57:48 AM changed by wwwluckyro

  • attachment example.png added.

opacity slider is ignored

02/29/2008 07:41:58 AM changed by boredzo

  • owner changed from nobody to boredzo.
  • status changed from new to assigned.

03/01/2008 11:26:50 PM changed by boredzo

  • component changed from Adium Core to Adium UI.

A cursory examination suggests that this is the fault of either the stringRepresentation method that we add to NSColor, or the representedColor method that we add to NSString. One or the other is not accounting for alpha.

This is a fine cue to add unit-tests for the NSColor additions.

03/02/2008 07:33:22 AM changed by boredzo

(In [22765]) Doxygenated AIColorAdditions. Next, I get to write unit tests to this documentation. Refs #9341.

03/03/2008 02:51:32 PM changed by wwwluckyro

I really like to see that you're actively working on this. I guess this bug reporting system actually works :P

03/04/2008 10:41:44 AM changed by boredzo

(In [22807]) Added test-case methods for -stringRepresentation with semi-transparent colors. These tests pass. Refs #9341.

03/04/2008 10:55:35 AM changed by boredzo

Interesting. The automated tests are telling me that the stringRepresentation and representedColor methods are working fine. The problem must lie elsewhere.

(Meanwhile, this is why automated testing is good. Now we have proof that those methods are working correctly.)

03/04/2008 01:18:10 PM changed by evands

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [22817]) Properly use the alpha value of the background color for the contact list, do a little reorganization to ensure that window opacity is updated properly, and note that invalidating shadows while drawing is still needed as of 10.5.2. Fixes #9341

03/04/2008 01:18:38 PM changed by evands

(In [22818]) Merged [22817]: Properly use the alpha value of the background color for the contact list, do a little reorganization to ensure that window opacity is updated properly, and note that invalidating shadows while drawing is still needed as of 10.5.2. Fixes #9341

03/04/2008 02:56:46 PM changed by wwwluckyro

Does this mean we'll see this fix in 1.2.4 ? :)

03/04/2008 03:17:42 PM changed by evands

  • milestone set to Adium X 1.2.4.

Indeed :)

03/10/2008 02:13:40 PM changed by wwwluckyro

Yep it's working great in the latest 1.2.4 beta :)

03/10/2008 02:19:50 PM changed by Robby

Thanks for the feedback, wwwluckyro! :)

03/11/2008 01:08:30 AM changed by wwwluckyro

Please see ticket #9429 as I think they are related in some way.