Adium

Ticket #9335 (closed defect: fixed)

Opened 8 months ago

Last modified 6 months ago

Bookmark chat allows bookmarking of single user conversations

Reported by: chckens Assigned to: evands
Priority: normal Milestone: Adium X 1.2.5
Component: Adium UI Version: 1.2.3
Severity: normal Keywords:
Cc: Patch: None
Pending: 0

Description

If I click the "bookmark the current chat" toolbar button in an ordinary conversation window on my Jabber account (i.e. with a single other participant rather than an MUC room), a useless entry gets added to my contact list, i.e. double clicking on this new bookmark does nothing.

(Makes me wonder why there are separate toolbar buttons for Add Contact and Add Bookmark... shouldn't a single "Add to Contact List" suffice for both situations?)

Change History

03/02/2008 12:07:20 AM changed by jas8522

  • milestone set to Adium X 1.2.5.

Good point... it should probably only work when there is more than one other person in the chat. Can we grey the button out unless the active tab is a MUC?

04/03/2008 01:19:02 PM changed by jas8522

  • summary changed from bookmark chat button "works" when it shouldn't to Bookmark chat allows bookmarking of single user conversations.

04/03/2008 02:52:17 PM changed by evands

  • owner changed from nobody to evands.
  • status changed from new to assigned.

You might want to add another contact (say, one that your friend just told you about) using Add Contact, though I'm not sure that's a strong enough reason not to combine the buttons into one. In any case, the bug itself is simple here :)

04/03/2008 02:52:48 PM changed by evands

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [23055]) Only enable the bookmark toolbar item if we're in a group chat. Fixes #9335

04/03/2008 02:53:16 PM changed by evands

(In [23056]) merged [23055]: Only enable the bookmark toolbar item if we're in a group chat. Fixes #9335