Adium

Ticket #8864 (closed defect: fixed)

Opened 8 months ago

Last modified 3 months ago

Creating a new chat with a new chat window for a contact that does not exist causes problems

Reported by: mtimmsj Assigned to: applmak
Priority: normal Milestone: Adium X 1.3
Component: AppleScript Version: 1.2
Severity: normal Keywords: AppleScript make new chat
Cc: Patch: None
Pending: 0

Description

When you run the following AppleScript for an account that exists but a contact that does not and you have no open chat windows, Adium creates a chat window that is invisible and has an id of -1:

tell application "Adium" to tell account "accountname" to make new chat  with contacts {contact "invalidcontactname"} with new chat window

You can see the id of the chat window with:

tell application "Adium" to get id of every chat window

After you have created one of these hidden windows, try opening a chat manually by double-clicking on a contact in the contact list. You get a chat window with two chat tabs, one chat tab has no name and is partially drawn. You can't close the chats by clicking on the icon in the tab, or by using the "Close Chat" option (command-w). If you try to send a message to the contact in the second chat tab it opens multiple chat windows in the window. If you close the window and try and open a new chat with the same contact by double-clicking on the contact in the contact list, Adium opens the old window (this might be normal if the windows stick around in case you open them again). The only way to get out of this weirdness is to restart Adium.

Change History

01/11/2008 04:45:38 PM changed by djmori

  • milestone set to Needs dev review.

01/14/2008 01:24:55 PM changed by mtimmsj

Tested on both Tiger and Leopard, and both have this issue.

03/13/2008 02:45:53 PM changed by mtimmsj

Another manifestation of this bug is if you don't use the "with new chat window" option. For example with:

tell application "Adium" to tell account "accountname" to set theChat to make new chat with contacts {contact "contactname"}

Even if the contact exists you get an error of: Adium got an error: Can't create chat in that chat window.

However, it does try to create a chat (the tab is created) and Adium is unstable at that point. I've only tested this manifestation on 1.3svn from a while back. I'll update to the latest svn and see if anything changes.

05/15/2008 08:38:16 AM changed by djmori

05/18/2008 04:17:26 PM changed by Robby

  • milestone changed from Needs dev review to Adium X 1.4.

1.4 for now.

06/09/2008 12:22:20 AM changed by Robby

  • owner changed from nobody to applmak.
  • milestone changed from Adium X 1.4 to Good idea for "later".

06/09/2008 01:40:49 AM changed by applmak

  • status changed from new to closed.
  • resolution set to fixed.

(In [23862]) When making a new chat, and we detect that an error has occurred... Rather than simply setting the error message and continuing, we now return nil, which stops futher processing and tells the user of the error. Fixes #8864.

06/09/2008 01:41:37 AM changed by Robby

  • milestone changed from Good idea for "later" to Adium X 1.3.

Cool! :)