Adium

Ticket #8757 (closed enhancement: fixed)

Opened 4 months ago

Last modified 4 months ago

Display alias in handle textfield by default

Reported by: jjay Assigned to: nobody
Priority: normal Milestone: Adium X 1.2.1
Component: Adium UI Version: 1.2svn
Severity: normal Keywords: handle
Cc: Patch: Initially Included
Pending: 0

Description

By default in the jabber joint conf room, the handle is empty. I think it's a good idea to set the account alias by default in the Handle textField.

I made a patch (on the file Plugins/Purple Service/DCPurpleJabberJoinChatViewController.m) to do that.

jjay

Attachments

alias_handle_patch.diff (0.6 kB) - added by jjay on 01/05/2008 08:07:02 PM.
Patch to display alias in Handle field
alias_handle_patch_2.diff (509 bytes) - added by jjay on 01/06/2008 06:16:55 AM.
Patch to display placeholder alias in Handle field
alias_handle_patch_3.diff (0.7 kB) - added by jjay on 01/07/2008 06:27:25 AM.
New patch solving the issue : The placeholder is not used when no handle is specified

Change History

01/05/2008 08:07:02 PM changed by jjay

  • attachment alias_handle_patch.diff added.

Patch to display alias in Handle field

01/05/2008 08:27:28 PM changed by jas8522

  • milestone set to Needs dev review.

01/05/2008 11:30:59 PM changed by evands

Is there a reason that you accessed the information as you did versus [account displayName]?

I think this should be a placeholder string rather than the actual string value.

01/06/2008 06:16:55 AM changed by jjay

  • attachment alias_handle_patch_2.diff added.

Patch to display placeholder alias in Handle field

01/06/2008 06:18:13 AM changed by jjay

You're right. I added a new patch (alias_handle_patch_2.diff) with your comments ! thx

01/06/2008 10:36:50 AM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [22141]) Patch from jjay which shows the account's display name as placeholder text for the 'handle' field when joining a Jabber group chat. Thanks! Closes #8757

01/06/2008 10:47:22 AM changed by Robby

1.2.1?

01/06/2008 10:59:17 AM changed by evands

  • milestone changed from Needs dev review to Adium X 1.2.1.

Truth!

01/07/2008 06:24:30 AM changed by jjay

Could ou please re-open this ticket. There is a issue : the placeholder is not use when not handle is specified. I made a new patch to solve this issue (alias_handle_patch_2.diff)

01/07/2008 06:25:18 AM changed by jjay

In my last comment it's : alias_handle_patch_3.diff and not alias_handle_patch_2.diff

01/07/2008 06:27:25 AM changed by jjay

  • attachment alias_handle_patch_3.diff added.

New patch solving the issue : The placeholder is not used when no handle is specified

01/07/2008 06:28:56 AM changed by evands

(In [22175]) Further patch from jjay to use the display name, falling back on the formattedUID, as the handle in Jabber group chats. Fixes #8757

01/07/2008 06:29:42 AM changed by evands

Ah, that's good - I hadn't tested in another client and had assumed (incorrectly) that I was just seeing an Adium bug that the handle wasn't being displayed. Thanks :)

01/14/2008 06:01:48 PM changed by evands

  • milestone changed from Adium X 1.2.1 to Adium X 1.2.2.

01/15/2008 09:54:52 PM changed by evands

  • milestone changed from Adium X 1.2.2 to Adium X 1.2.1.

01/23/2008 01:46:11 PM changed by rsmclane

Running Adium 1.2.1, I still seem to be having this issue. When I join a jabber group chat, my alias place holder is displayed but when I join the chat, it's not used.

01/23/2008 05:56:46 PM changed by jjay

Yes you're right ! I juste downloaded the latest adiu release (1.2.1) and the placeholder is not used :(

I think the latest patch alias_handle_patch_3.diff is not inclued in adium 1.2.1 !

evands am I right ?

01/23/2008 06:00:55 PM changed by jjay

I just verified, the last patch is in trunk but not in root/tags/AdiumX_1.2.1 :( The next release 1.2.2 solve this issue.

01/23/2008 07:41:10 PM changed by evands

(In [22466]) Merged [22175]: Further patch from jjay to use the display name, falling back on the forma ttedUID, as the handle in Jabber group chats. Fixes #8757