Adium

Ticket #8729 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

iChat Import Assistant hangs when it tries to convert an alias

Reported by: Thunderforge Assigned to: nobody
Priority: normal Milestone: Adium X 1.2.1
Component: Adium Core Version: 1.1.4
Severity: normal Keywords: iChat Import Assistant
Cc: Patch: None
Pending: 0

Description

When using the iChat Import Assistant to import chat transcripts, it hangs if an alias is in the "iChats" folder. iChat Import Assistant will sit there doing nothing (it does not freeze the program though). Moreover, if the user tries to cancel the import, the Assistant will just sit there doing nothing. This appears to happen both with aliases to folders and to files.

Attachments

console.log (268 bytes) - added by Thunderforge on 01/06/2008 09:51:32 PM.
Console Output, Adium 1.2

Change History

01/02/2008 08:59:29 PM changed by Thunderforge

After a bit more researching, I discovered that the iChat Import Assistant will try to convert ANY type of file. For example, if there is a .txt file in the "iChats" folder, it will try to convert it (and will say it was successful, not sure what to make of that). It will even try to import a .app file (in which case it will try to import the package contents).

The simple workaround for all this is to have the iChat Import Assistant simply check to make sure the file it is trying to import ends with a .ichat extension, signaling that what it is trying to import is indeed an iChat transcript file and not something else.

01/02/2008 09:26:23 PM changed by jas8522

  • milestone set to Adium X 1.2.2.

I assume you can reproduce this with the 1.2 AdiumBeta? As far as I know nothing was changed in the importer.

01/03/2008 01:37:26 PM changed by evands

Any Console output when this happens?

01/06/2008 09:51:32 PM changed by Thunderforge

  • attachment console.log added.

Console Output, Adium 1.2

01/06/2008 09:55:10 PM changed by Thunderforge

Turns out there was Console output. I went ahead and uploaded the log. The error in the log report was written after the import process began, and no error was created when I clicked "Cancel Import." To make the log, I had one alias in the "iChats" folder and no other files. The same thing happens in both Adium 1.1.4 and Adium 1.2.

01/06/2008 10:05:39 PM changed by evands

So what sort of alias do you have in iChats, anyways? Is it an alias to a log file, or to another location which iChat was using and which you would expect to be imported by Adium?

01/06/2008 10:09:30 PM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [22159]) Resolve aliases passed to BGICLogImportController, and catch exceptions thrown by the NSKeyedUnarchiver/NSUnarchiver when attempting to parse an iChat log and log them rather than crashing. Fixes #8729

01/06/2008 10:09:42 PM changed by evands

  • milestone changed from Adium X 1.2.2 to Adium X 1.2.1.

01/06/2008 10:10:29 PM changed by evands

(In [22160]) Merged [22159]: Resolve aliases passed to BGICLogImportController, and catch exceptions thrown by the NSKeyedUnarchiver/NSUnarchiver when attempting to parse an iChat log and log them rather than crashing. Fixes #8729

01/07/2008 06:02:48 PM changed by Thunderforge

The alias I had in the iChats folder was actually to an older application I had for converting iChat transcripts to text (so I'd just take the transcript file I wanted to convert to text and drop it on the alias to convert it). I hadn't thought about aliases to other folders with chats in them, but I suppose somebody might try that. At any rate, you seem to have the problem fixed, so I applaud you for that.

01/14/2008 06:01:48 PM changed by evands

  • milestone changed from Adium X 1.2.1 to Adium X 1.2.2.

01/15/2008 09:54:52 PM changed by evands

  • milestone changed from Adium X 1.2.2 to Adium X 1.2.1.