Adium

Ticket #8445 (closed defect: fixed)

Opened 6 months ago

Last modified 4 months ago

& in URLs over-escaped to &

Reported by: deeaytch Assigned to: nobody
Priority: normal Milestone: Adium X 1.2.1
Component: Adium Core Version: 1.1.4
Severity: normal Keywords:
Cc: Patch: None
Pending: 0

Description

Send yourself (or anyone else, or have someone send you) an URL with an ampersand in it. Say, http://example.com/this&that

Click on it in the message window. Works fine (in this case, a 404, but you got sent to the right place). Close the message window, and View Chat Transcripts. Works fine again.

Re-open the message window (assuming "Show recent messages in new chats" is checked in preferences, and this message is still recent enough to be shown). Click. You'll get sent to http://example.com/this&that -- oops.

Change History

11/24/2007 07:13:44 PM changed by jas8522

  • milestone set to Adium X 1.2.1.

Indeed. Confirmed on 1.2svn r21721

This seems to be occuring when it pulls the recent history from the chat logs (or buffer?) and displays it. I was using modern bubbling when I tested it.

01/11/2008 10:45:42 PM changed by evands

This looks just like #6850

01/11/2008 10:52:05 PM changed by evands

Nm, it's the opposite.

01/11/2008 11:07:36 PM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [22266]) Unescape the HREF attribute's text before passing it to NSURL which does not expect XML/HTML-escaped entities. Fixes #8445

01/11/2008 11:08:03 PM changed by evands

(In [22267]) Merged [22266]: Unescape the HREF attribute's text before passing it to NSURL which does not expect XML/HTML-escaped entities. Fixes #8445

01/12/2008 12:06:36 AM changed by boredzo

(In [22275]) Merged r22274 from trunk: -stringByUnescapingFromXMLWithEntities: takes an object instance, not a general pointer. Thus, the correct constant is nil, not NULL.

I forgot to mention this part previously: Refs r22266 on trunk; refs r22267 on this branch; refs #8445.

01/14/2008 06:01:48 PM changed by evands

  • milestone changed from Adium X 1.2.1 to Adium X 1.2.2.

01/15/2008 09:54:52 PM changed by evands

  • milestone changed from Adium X 1.2.2 to Adium X 1.2.1.