Adium

Ticket #812 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Too Easy to delete Logged Chats

Reported by: tedger Assigned to: nobody
Priority: normal Milestone:
Component: Logging Version: 0.82
Severity: normal Keywords: log viewer delete key-commands
Cc: tedger@gmail.com Patch:
Pending:

Description

I was just searching for a log in the log viewer. I typed in what I thought would find me the log, and realized that I needed to try something else. So I started hitting delete to delete the search term only to realize that I was deleting logs. I think for just a key command it should be something like cmd+delete or have a confirmation window pop up (I'm much more in favor of the more complex key command). Just a minor thing, but when you delete your last week's conversations with a person that's coming into town tomorrow and you were looking at the logs to figure out when, it suddenly becomes less minor. Oh and no biggy I found the time in an e-mail.

Change History

07/03/2005 01:38:26 AM changed by boredzo

  • priority changed from low to normal.
  • severity changed from enhancement to normal.

I see two issues here:

  1. clearly the responder chain in the log viewer window is wrong; the delete command should be captured by the search field only.
  2. we should make the 'Delete Log' command cmd-delete, to be consistent with 'Delete Contact' and avoid this problem.

07/03/2005 03:51:40 AM changed by evands

Agreed.

Also, a note: If the delete key isn't sending logs to the trash (rather than deleting them immediately), it should be. We should use the Undo manager if possible to bring the log file back from the trash to its original location if the user picks Undo.

09/11/2005 02:20:08 PM changed by evands

We can't use cmd-delete for deletion of logs because the Delete Contact menu item grabs the keystroke before it ever gets to the table.

09/11/2005 02:22:06 PM changed by zacw

Use opt+delete; iTunes uses it to delete songs when you're not in the library...

09/20/2005 04:33:41 PM changed by evands

But that's non-standard... I don't think users would know to use that combination.

11/14/2005 10:52:11 PM changed by tick

  • milestone set to Adium X 1.0.
  • field_haspatch changed.

11/19/2005 06:08:00 AM changed by catfish_man

  • milestone deleted.

Removing the milestone, because the relevant ticket (#38) now links to it.

05/27/2006 03:55:32 AM changed by catfish_man

  • status changed from new to closed.
  • resolution set to fixed.

06/22/2006 07:03:30 PM changed by evands

  • status changed from closed to reopened.
  • resolution deleted.

Consolidating tickets as we did for logging is probably not productive unless they are very nearly duplicates...

Reopening this as it has not been addressed. It is not a requirement for 1.0, as it is not a regression or a huge problem (deleting logged chats sends them to the trash, so it's effectively nondestructive.)

Fixing this ticket should also include adding undo support for the delete log operation, which should be reasonably easy.

07/08/2006 04:28:32 AM changed by evands

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [16703])

  • Deletion of contacts and associated logs is now supported from the log viewer's contacts source list
  • Deletion of multiple logs now shows a confirmation dialogue
  • Fixed a crash when deleting a single log
  • Added undo support for log deletion

Fixes #812. Fixes #4509. Fixes #4478. Fixes #4278.