Adium

Ticket #8112 (closed enhancement: fixed)

Opened 1 year ago

Last modified 4 months ago

Patch to Psychic Plugin

Reported by: adyess Assigned to: nobody
Priority: normal Milestone: Adium X 1.3
Component: Plug-Ins Version:
Severity: normal Keywords:
Cc: Patch: Needs Changes by Author
Pending: 0

Description

instead of just setting the setStatusObject field of the contact when the user is being spoken to by a remote user, i've made the psychic plugin behave more like the pidgin psychic plugin.

it will open the chat window for the user and prompt them with a message stating they feel a disturbance in the force. i've been using this feature in pidgin and really like it for adium.

Attachments

psychic.diff (1.7 kB) - added by adyess on 10/13/2007 04:42:51 PM.

Change History

10/13/2007 04:42:51 PM changed by adyess

  • attachment psychic.diff added.

10/13/2007 07:22:09 PM changed by edr1084

  • milestone set to Needs dev review.

10/14/2007 12:50:12 AM changed by evands

  • patch_status changed from Needs Dev Review to Needs Changes by Author.

Sounds good and fun. Some critiques:

  • Please make the new string added in your patch localizable using the AILocalizedString() macro. All displayed strings must be localizable.
  • Make sure your code follows the CodingStyle guidelines. First thing I"ve noticed is that curly braces should be on the same line as if() statements, and spacing should be respected within if() statements.
  • Don't comment out code you're replacing; just remove it.
  • You should not need to do a cast to (AIChat *) when calling chatWithContact:. Remove that; if you get a warning as a result, check your imports at the top of the file.

10/14/2007 12:53:32 AM changed by zacw

Since a relevant search would likely find this, the psychic plugin can be fund at http://trac.adiumx.com/browser/plugins/trunk/Psychic -- one of these days it'll go up on the Xtras site.

10/14/2007 01:03:02 AM changed by zacw

Mac-arena pointed out on IRC -- perhaps this plugin should be shifted over to opening the chats, and the typing status adopted as default behavior? It seems pretty slick (and obvious), whilst the chat opening is definitely plugin-quality material.

10/14/2007 03:51:15 AM changed by edr1084

My only suggestion would be possibly having two versions: 1. would maintain the current functionality of letting you see who is going to talk to you without taking any action, 2. would open the chat.

Reason being, sometimes it's nice to see if someone is about to talk to you (for whatever reason, I don't have one but sometimes I think it's fun ;) ) but you don't necessarily want to consistently bug people. (Some people tend to get freaked out by things they don't understand and may not want to talk to you anymore...)

(follow-up: ↓ 7 ) 10/14/2007 03:53:30 AM changed by boredzo

edr1084: Two versions?

My proposal is to build in the functionality of lighting up the typing indicator without a chat, as I see no grounds for objection to that, and to make the plug-in's sole function to open the chat window on typing.

(in reply to: ↑ 6 ) 10/14/2007 04:03:26 AM changed by edr1084

Replying to boredzo:

My proposal is to build in the functionality of lighting up the typing indicator without a chat, as I see no grounds for objection to that, and to make the plug-in's sole function to open the chat window on typing.

Perfect.

01/22/2008 04:31:29 AM changed by jchang

Looking at the trunk, I think Evan finished it up? And I saw a little mention of this during 01-17-08 meeting. In any case, would someone be willing to post this up on the xtras site?

01/22/2008 08:01:23 PM changed by evands

The typing indicator part is in trunk for 1.3. This patch has not been updated per the changes requested above so has not been committed for the external Psychic plugin.

05/15/2008 08:38:14 AM changed by djmori

06/08/2008 07:03:32 PM changed by zacw

  • status changed from new to closed.
  • resolution set to fixed.

(In [23856]) Last minute addition to the advanced Message preferences: "Open chats as soon as contacts begin typing" -- this behaves exactly like the Pidgin plugin, which opens a new chat and displays "You feel a disturbance in the force..." when someone begins typing to you. This also adds a stop to processing the psychic stuff for non-contact-list contacts. Fixes #8112.

06/08/2008 07:09:43 PM changed by Robby

  • milestone changed from Needs dev review to Adium X 1.3.

06/08/2008 07:26:53 PM changed by zacw

(In [23857]) Move the chat-opening psychic stuff over to the account to deal with the opening, reducing the preference reading, and making it a bit more readable overall. Refs #8112.