Adium

Ticket #8012 (reopened defect)

Opened 1 year ago

Last modified 5 months ago

Use pixel size to scale buddy icons

Reported by: edr1084 Assigned to: boredzo
Priority: normal Milestone: Good idea for "later"
Component: Adium Core Version: 1.2svn
Severity: normal Keywords:
Cc: Patch: None
Pending: 0

Description

A friend of mine recently changed her buddy icon. The image is 64x56 but appears to be quite small because it is 300dpi. I think we should be respecting the pixel size in this regard because the result seems to be quite silly. (See attached image.)

Attachments

buddyIcon.jpg (11.6 kB) - added by edr1084 on 09/30/2007 07:46:55 PM.

Change History

09/30/2007 07:46:55 PM changed by edr1084

  • attachment buddyIcon.jpg added.

09/30/2007 07:47:42 PM changed by edr1084

I'm setting this to 1.2 but it can easily be pushed back because it is neither a regression nor a blocker.

09/30/2007 08:13:27 PM changed by boredzo

  • owner changed from nobody to boredzo.
  • status changed from new to assigned.

09/30/2007 08:15:46 PM changed by boredzo

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [21195]) * Added method to NSImage: -sizeInPixels. Does what it says on the box.

  • Changed -drawRoundedInRect:atSize:position:fraction:radius: to use -sizeInPixels rather than -size to determine the scale factor. Fixes #8012, and I believe this fixes the issue at the heart of it (high-res buddy icons drawn at postage-stamp size).

09/30/2007 09:11:38 PM changed by edr1084

  • status changed from closed to reopened.
  • resolution deleted.

Still no go. I recompiled and both of us have signed on and off. Also trying to change the icon manually to something else (a 300dpi test image) fails to scale properly. :(

10/25/2007 12:10:13 PM changed by sbriglie

I can confirm that the bug is still present in r21292

11/02/2007 07:09:13 PM changed by edr1084

Related to #8181.

11/02/2007 07:11:42 PM changed by edr1084

Just like in the other ticket, the cached image displays at normal size in preview. Displays properly in the official client.

(follow-up: ↓ 10 ) 11/03/2007 10:58:01 AM changed by boredzo

Eric, are you saying that my fix for this ticket caused #8181? If so, then no, that's not possible: r21195 was never merged to the adium-1.1 branch.

11/03/2007 12:03:35 PM changed by boredzo

(In [21476]) Reverted r21195, as it did not fix the problem (#8012) and should be more likely to cause it than fix it anyway. Refs #8012.

(in reply to: ↑ 8 ) 11/03/2007 04:28:44 PM changed by edr1084

Replying to boredzo:

Eric, are you saying that my fix for this ticket caused #8181? If so, then no, that's not possible: r21195 was never merged to the adium-1.1 branch.

I certainly don't think you caused it (and as you said, you couldn't have). I was simply saying that the two issues probably share the same root cause.

11/03/2007 04:45:00 PM changed by evands

The test app I attached #8181 is directly relevant to this ticket.

11/15/2007 01:57:20 PM changed by evands

  • milestone changed from Adium X 1.2 to Adium X 1.2.1.

01/10/2008 01:29:58 PM changed by evands

  • milestone changed from Adium X 1.2.1 to Good idea for "later".

05/15/2008 08:38:13 AM changed by djmori