Adium

Ticket #7542 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

"Check For Updates..." systematically crashes adium

Reported by: mij Assigned to: nobody
Priority: normal Milestone: Adium X 1.0.6
Component: Adium Core Version: 1.1
Severity: blocker Keywords: check updates sparkle sparkleplus crash
Cc: Patch: None
Pending: 0

Description (Last modified by boredzo)

Since Adium 1.1, 90% of the times you use "Check for Updates..." from the Adium menu makes Adium crash with a Segmentation fault.

This is the output from console:

CMSCreateDataProviderOrGetInfo : Invalid colorspace type
CMSCreateDataProviderOrGetInfo : Invalid colorspace type
CMSCreateDataProviderOrGetInfo : Invalid colorspace type
[now clicking "Check For Updates..."]
Segmentation fault

Attachments

adium11checkupdatescrash.txt (21.2 kB) - added by mij on 08/13/2007 12:01:16 PM.
crash dump
Adium.crash.log (41.6 kB) - added by starryeyedhaze on 08/13/2007 02:44:42 PM.
Adium Crash Log from Today.
20070813_adiumx_1.0.5_crashlog_when_updating.txt (21.7 kB) - added by heywoodj on 08/13/2007 04:41:27 PM.
Crashlog on MacBook Pro / Tiger 10.4.10
adium_crash.txt (21.6 kB) - added by dang on 08/13/2007 04:56:47 PM.
adding my crash log from 7543

Change History

08/13/2007 12:01:16 PM changed by mij

  • attachment adium11checkupdatescrash.txt added.

crash dump

08/13/2007 12:28:59 PM changed by Catfish_Man

  • milestone set to Adium X 1.1.1.

That's bizarre...

(follow-up: ↓ 11 ) 08/13/2007 01:11:01 PM changed by evands

Is this reproducable on other machines? We should push a fix for this ASAP if it's happening on automatic version checks, in particular, or we'll have a bunch of people locked into 1.1.

08/13/2007 01:17:49 PM changed by Catfish_Man

We've gotten a *ton* of reports on irc

08/13/2007 01:45:50 PM changed by zacw

#7543 for a ton of info.

08/13/2007 01:48:23 PM changed by evands

What do you think about updating adiumx.com/changelogs/1.1.html to have big red blinking text not to upgrade if using 10.3 and then removing the minimum system requirement stuff from the appcast? It seems really really likely that it's the culprit.

08/13/2007 01:50:03 PM changed by zacw

What's strange is, it's not a 100% crash on check for me. It only crashes ~1/3 of the time. Otherwise it says it had an error checking (?) or I'm up to date.

As a temporary fix, definitely. If everybody is crashing as often as I am... oi.

08/13/2007 02:44:06 PM changed by starryeyedhaze

This happens to me on multiple machines every time I launch Adium 1.0.5. I thought it was just a settings issue at first, but then I came home and it happened on my PowerBook G4. My other machine is a PPC Mac Mini. I'm attaching the crash log.

08/13/2007 02:44:42 PM changed by starryeyedhaze

  • attachment Adium.crash.log added.

Adium Crash Log from Today.

08/13/2007 04:40:36 PM changed by heywoodj

Consistent crashes for me except when I had myself marked as "Available." If I used Away, Invisible, etc., I would see the pop-up indicating it was trying to contact the update server, then... *boom*. This is AdiumX 1.0.5 on a MacBook Pro, 10.4.10. On the off chance that it might yield some additional (non-redundant) info, I'm attaching a crash log as well.

Resolution for me: set to Available, update normally; 1.1 runs fine (no crashes so far, unlike what others have reported).

08/13/2007 04:41:27 PM changed by heywoodj

  • attachment 20070813_adiumx_1.0.5_crashlog_when_updating.txt added.

Crashlog on MacBook Pro / Tiger 10.4.10

08/13/2007 04:56:47 PM changed by dang

  • attachment adium_crash.txt added.

adding my crash log from 7543

08/13/2007 04:58:54 PM changed by dang

I added my crash log. On MacPro with 10.4.10. Crash happens upon every start of Adium. The contact list begins to load and then the crash happens.

I'm running 1.1. I tried re-install but it did not fix the issue.

08/13/2007 05:08:31 PM changed by mfazekas

I've built a debug version of adium with a debug version of SparklePlus and i was able to repeat the crash 100% (even under debugger).

Then i've stepped through the code in SparklePlus, and it didn't crash.

Now i'm unable to reproduce the crash - nor with debug/release version. So it might be some settings related bug.

(in reply to: ↑ 2 ) 08/13/2007 07:02:09 PM changed by mij

Replying to evands:

Is this reproducable on other machines? We should push a fix for this ASAP if it's happening on automatic version checks, in particular, or we'll have a bunch of people locked into 1.1.

I can confirm I get this behavior with nearly the same frequency on these machines:

  • Intel MBP (2.16GHz second release) with OS X 10.4.10
  • Intel MBP (Santa Rosa) with OS X 10.4.10
  • PowerPC iMag G5 with OS X 10.4.10

08/13/2007 07:06:15 PM changed by boredzo

  • description changed.
  • severity changed from normal to blocker.

This bug is in 1.0.5 and 1.1, and was revealed by my fix to the appcast this morning.

The bug is simple: One of the piece of data from the appcast wasn't being retained, so when Sparkle Plus tried to use it again later, it was a dead object, which caused a crash.

This bug is only in Sparkle Plus. It was fixed five months ago in Sparkle, but somehow, the fix never made it to Sparkle Plus, which is how it never made it to Adium.

We're still working on exactly how we should roll out the fix, but we do think we've found and fixed the problem. I'm updating the description accordingly, to hopefully stem the flow of confirmations. Thanks to all the users who've helped out with this.

08/13/2007 07:07:06 PM changed by boredzo

  • keywords changed from check updates crash to check updates sparkle sparkleplus crash.
  • description changed.

s/h3/h2/

08/14/2007 12:58:52 AM changed by boredzo

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from Adium X 1.1.1 to Adium X 1.0.6.

Fixed by r20578 and r20585 for 1.0.6, and r20577 and r20585 for 1.1.1.

08/14/2007 12:59:31 AM changed by boredzo

  • description changed.

Removed “We don't need crash logs now” message. If you get this same crash with 1.0.6 or 1.1.1, please do attach the crash log.