Adium

Ticket #7388 (closed defect: fixed)

Opened 1 year ago

Last modified 5 months ago

can't re-join jabber groupchat after disconnect

Reported by: larse Assigned to: nobody
Priority: high Milestone: Adium X 1.3
Component: Jabber/XMPP Version: 1.1b3
Severity: major Keywords:
Cc: am Patch: None
Pending: 0

Description

When I get disconnected from the network while participating in a jabber group chat, I cannot re-join the same group chat using the same handle when connectivity comes back. Sometimes (but not always) I'll get an error message simply saying "Conflict".

This isn't new with 1.b3, AFAIK this problem has existed with the various 1.0.x versions as well.

Change History

08/14/2007 11:03:31 PM changed by jas8522

  • status changed from new to closed.
  • resolution set to duplicate.

#1880

08/28/2007 12:48:05 AM changed by irabinovitch

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone deleted.

I am unable to reproduce in this in Adium 1.1 or 1.2svn. Can you please test with a current version of Adium and let us know you are still running into this issue? I have tested on GTalk, Jabber.org, and a personal jabber server.

(follow-ups: ↓ 4 ↓ 5 ) 08/30/2007 06:31:50 PM changed by luapffuh

I think this is just a side-effect of the way that AIChatController.m:381-392 checks to see if an extant named chat already exists before joining a new one. I don't know that this is necessarily a bug, as much as poor group chat handling?

(in reply to: ↑ 3 ) 08/30/2007 06:34:30 PM changed by luapffuh

Replying to luapffuh:

I think this is just a side-effect of the way that AIChatController.m:381-392 checks to see if an extant named chat already exists before joining a new one. I don't know that this is necessarily a bug, as much as poor group chat handling?

Also, if you close the group chat, and then re-join it works just fine...

(in reply to: ↑ 3 ) 11/13/2007 04:13:19 PM changed by erik006

  • cc set to am.

I do not believe this is true. As far as I know that "bug" (which was unreported iirc), was solved by Evan back in the summer and got committed to the SoC branch. Afaik, that change is also in trunk now.

Now, I think this is the same bug AM & I stumbled upon in the summer. It also seems to happen for me when I use a name close to my username joining an empty chat. If I remember correctly, this is a fundamental design issue, and would require a rewrite of the chatcontroller.

The related bug would be #1874

11/16/2007 10:05:57 AM changed by erik006

  • priority changed from normal to high.
  • severity changed from normal to major.

I believe this should be handled, since it can be a huge problem when using xmpp.

11/16/2007 10:40:55 AM changed by jas8522

This still sounds like a duplicate of #1880 to me. If it is, then this should probably be closed, if it's not then a distinction should be made between them.

11/19/2007 10:40:41 AM changed by erik006

This is not a duplicate for the following reason: This tickets talks about the "409 Conflict" that occurs when you try and join a jabber group chat, whereas the other ticket talks about the fact that adium doesn't join group chats automatically.

Erik

11/19/2007 10:44:04 AM changed by jas8522

Erik,

That makes sense, but I would think Adium would attempt to autmoatically re-join the chat but it fails because of this bug. If that's true then #1880 relies completely on this ticket to be fixed, otherwise they are indeed mutually exclusive.

12/25/2007 03:04:05 PM changed by jas8522

  • milestone set to Adium X 1.3.

Temporary milestone. I assume this can be reproduced with the 1.2 beta?

03/03/2008 10:37:50 PM changed by durin42

I've been seeing this on 1.2.2 and 1.2.3, for what it's worth.

04/28/2008 10:15:53 PM changed by evands

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [23232]) im.pidgin.pidgin 2.4.2mtn @ b28057d6ade7c221b0616c3b02e86659e2d8b10b which adds a chat-join-failed signal. We then make use of it to know when joining a group chat fails (currently only works for jabber chats) and remove our reference to the corresponding AIChat. Fixes #1874. Fixes #7388.