Adium

Ticket #721 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 years ago

Smilies displaying mid-word

Reported by: marshall@exclupen.com Assigned to: evands
Priority: normal Milestone: Adium X 1.0
Component: Core Adium Version: 0.82
Severity: normal Keywords: emoticon
Cc: Patch:
Pending:

Description

Smilies are showing up in the middle of words, and they probably shouldn't.

Examples:

t:)est

Net::SSH::Pari

Smilies should only match when there is a space before them, after them, or both.

Change History

06/22/2005 02:35:14 PM changed by anonymous

While those of us who type properly put spaces before/after emoticons, a lot of people don't. What would be neat, however, is the disabling of emoticons as a temporary basis (view > emoticons on/off) or something.

06/22/2005 02:39:22 PM changed by marshall@exclupen.com

So it's better to cater to the people doing the wrong thing? I think it's more confusing to see an emoticon in the middle of a word than to see a bare ":)"

And maybe people would start typing better if their emoticons didn't work. There's no harm in that. :)

06/22/2005 02:41:54 PM changed by marshall@exclupen.com

  • keywords set to emoticon.
  • owner changed from nobody to anybody.
  • component changed from AIM to Core Adium.
  • severity changed from normal to enhancement.

Bug #703 looks like another specific case of this problem.

06/22/2005 02:48:31 PM changed by anonymous

How would somebody using another client know if it displays different on mine? If every other client is displaying mid-word, we'd be the odd man out doing something strange for no particular reason.

06/22/2005 02:57:39 PM changed by adiumx@happywaffle.com

Putting spaces around our emoticons counts as "doing something strange"? Sounds like a reasonable thing to me! I don't care whether my buddies using other clients see emoticons at weird times. I just want them to show up at logical times on MY client.

06/22/2005 03:28:46 PM changed by marshall@exclupen.com

I see what anonymous is saying... people in other clients see smilies in mid-word, but you won't, so they'd continue doing the wrong thing and you'd see ":)" sometimes. Personally, I'd still rather see ":)" than a smiley mid-word.

AIM and (I assume) Gaim show the emoticon. iChat does not.

If people aren't going to go for this change, I'd at least settle for a preference.

06/22/2005 05:01:35 PM changed by evands

I'm with marshall. Emoticons should never be displayed inside links or inside words. An emoticon should display as an image if:

  • It is surrounded by spaces
  • It borders another emoticon
  • It ends a line

Marking #703 as a duplicate of this, as I like this discussion better.

06/22/2005 05:02:51 PM changed by evands

  • owner changed from anybody to nobody.

Please don't assign tickets (especially not to the non-existant person anybody)

08/25/2005 10:27:45 AM changed by john@kershaw.org

I just hit this when pasting an FTP URL into Adium. sftp://user:pass@url.com:22/home/user/web/files puts a wry smiley in the middle of the protocol! This doesn't happen with http://... so I'm guessing Adium's already checking for those. Could it be extended to any protocol? (\w+://)

John.

08/25/2005 10:30:34 AM changed by zacw

sftp isn't a recognized protocol in Adium. I suggest you make a separate ticket for it.

10/05/2005 11:40:15 PM changed by evands

  • milestone set to Adium X 1.0.

11/18/2005 01:01:15 AM changed by anon-ymous

this is an issue for times as well. 11:00 is displayed as 11"Some simlie"0. i don't see why this is even an arguable issue... don't we want things displayed correctly? who cares what every other client is doing? this is the BEST client, and as such, should not need to be "the same"... at version 0.86, as i am using, we haven't decided this argument yet? evands, i'm with you...

12/07/2005 06:56:32 PM changed by tick

  • owner changed from nobody to evands.
  • field_haspatch changed.

Is this something we want to look into for 1.0?

12/16/2005 10:37:40 AM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [14454]) An emoticon now displays if and only if one of the following is true:

  • It begins or ends the string
  • It is bordered by spaces or line breaks on both sides
  • It is bordered by a period on the left and a space or line break the right
  • It is bordered by emoticons on both sides or by an emoticon on the left and a period, space, or line break on the right

No more "sad code!"

Fixes #721.

12/16/2005 10:42:24 AM changed by David Munch

Just curious, does that mean that "hey dude:) " wont give you a smiley?

04/19/2006 02:37:28 AM changed by anonymous

David Munch has a point. If there is only whitespace after the emoticon, it should still be shown. Anyway, that works just fine in 0.89, but I still get a smiley in the middle of URLs (http://).

04/19/2006 02:51:37 AM changed by cbarrett

Should probably just run something like trim() on the string before examining it, or what not. I agree with the two above commenters.

04/19/2006 06:24:04 AM changed by evands

(In [15830]): Fixed an edge case with smiley parsing: If a smiley is at the beginning or end of the line after trimming whitespace it should be displayed graphically. This check is done last because -[NSString stringByTrimmingCharactersInSet:] is more expensive than other things done for the emoticon.

04/19/2006 06:24:48 AM changed by evands

anonymous, milestone on this ticket is Adium 1.0; you won't see any change until 1.0.