Adium

Ticket #7110 (closed defect: fixed)

Opened 1 year ago

Last modified 4 months ago

Aliases should not always be resolved when sending files

Reported by: adium Assigned to: evands
Priority: normal Milestone: Adium X 1.3
Component: Adium Core Version: 1.0.4
Severity: normal Keywords: alias file transfer
Cc: Patch: None
Pending: 0

Description

It was reported in #6601 that aliases should be resolved when sending files via Adium. I came across a situation today where that is definitely not the desired behaviour.

A co-worker, also using Adium 1.0.4, was sending me an application that has 17 frameworks contained within. Of course, by design there are many aliases within each framework and there was a helper app also inside the application's Resources folder that makes use of the same frameworks, and so just aliased back to Contents/Frameworks (the helper app is only about 300Kb).

Normally, the application is 13.2MB. After being sent to me via Adium (the application was dragged to my AIM contact whereupon Adium zipped the app and sent it off) the application had ballooned to 95.2MB due to all the aliases in the frameworks being resolved. And, since the helper app aliases to Contents/Frameworks, a complete second copy of the directory was then placed within the helper app (30MB for the main app and 30MB for the helper app).

I feel this is an incorrect behaviour and posit that aliases should not be followed when sending files.

I see the milestone in #6601 is set as 1.1; did this change get rolled back into a 1.0.x release and is causing the behaviour I'm seeing, or is it something else?

Change History

07/06/2007 05:58:53 PM changed by jas8522

  • keywords changed from alias,file,transfer to alias file transfer.
  • owner changed from nobody to evands.
  • milestone set to Needs dev review.

I think this is a good point - many applications (and other folders) have symlinks/aliases to system libraries or preferences that the user does not need to send. I can't think of any good circumstance for needing to follow an alias since anyone actually using aliases themselves should know what they do and not send them as files, but I'm probably not thinking of some other scenario.

02/11/2008 01:38:40 PM changed by evands

This is the fault of the tool being used to create the archive for sending, as we zip the folder/app and then send it.

05/15/2008 08:38:10 AM changed by djmori

06/09/2008 09:46:10 AM changed by Robby

  • status changed from new to closed.
  • resolution set to invalid.
  • milestone deleted.

According to Evan this is not Adium's fault.

06/09/2008 10:39:27 AM changed by evands

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone set to Adium X 1.3.

Thanks for bringing this back to the top of the timeline :) Upon further review, we should be able to use the -y option: 

       -y     Store symbolic links as such in the zip archive, instead of com-
              pressing  and  storing  the  file  referred to by the link (UNIX
              only).

to do this properly.

06/09/2008 10:44:56 AM changed by evands

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [23871]) Pass -y to zip when creating an archive to keep symbolic links as such rather than resolving them. Fixes #7110