Support for sending MSN custom/dynamic emoticons

Bumping to 0.9 for now, since this is pretty darn nontrivial.

Needs libgaim side support.

Adding some information:

Patch applied in libgaim: [ 1280944 ] [HEAD] Receiving and viewing custom MSN smilies https://sourceforge.net/tracker/index.php?func=detail&aid=1280944&group_id=235&atid=300235

I hope it gets implemented in Adium ;)

Ok, this ticket was closed before because we had no support in libgaim. I've checked out and the patch works just fine. So this could be some future work on adium, to support this patch with cocoa and stuff. I'll reopen it, not sure if this is the right action. Sorry if it isen't.

Thanks for the heads up.

The request in this ticket is for being able to send custom emoticons over MSN. Libgaim does not support that at this time (the patch linked above only enabled viewing; it has been, by the way, accepted into gaim 2.0 cvs already).

Adding some information: http://sourceforge.net/tracker/index.php?func=detail&aid=1429899&group_id=235&atid=300235

From what I can read here it is possible to view custom emoticons in Adium (gaim) without having to install them. The thing is i could only find the .diff patch and to be honest, i dont know how to apply it. Could someone please send me the patched file o help me out patching it myself?

Thanks

isaac_baley@hotmail.com

it will be fixed for adium 1.0

well adium is 1.0 is here and it's not fixed, although there's a lot of fluff about it from developers - adium displays question makrs instead of custom emoticons, just like before

No, 1.0 is NOT here. What part of beta did you miss? Get lost, and feel free to come back and *nicely* report that this isn't fixed IF it's not fixed for 1.0 final. The re-breaking of MSN custom emoticons is a recent regression.

It's better to remove something completely if it's getting complaints than to support it in only a halfway good manner. Maybe we should just remove MSN altogether? ;)

And no, this will not be fixed in 1.0, nor implemented in 1.0,nor was it ever going to be. wengero was not correct when posting above. Note that the milestone on this ticket is not set to 1.0.

It definitely needs an option to switch it off though. I find MSN custom emoticons highly annoying... often you can barely make out what people mean.

I think that is important to see emoticons. Many people talk using emoticon, I don't like it but it's the true. So i HAVE TO use mercury that really really sucks if you see Adium! I think it's a good thing if you make it possible to send and receive them in the right way.

Many people are tired of aMSN and Mercury and are waiting to see this important feature in Adium!

This is only a suggestion of course, your work is great anyway! Sorry for my crappy english. :)

Patch under review for MSNP14 branch merge

http://developer.pidgin.im/ticket/1187

#6231 presents also saving for later sending

important things

There's a new release of the custom emoticons patch: http://developer.pidgin.im/ticket/1187 "Good news. I have attached 3 patches to be reviewed. they are finished."

looks like there the libpurple patch has been commited, http://developer.pidgin.im/ticket/1187

Can't wait to see this feature in adium!

If possible, it would be nice to have 3 options: • Show custom emoticons. • Show custom emoticons and scale them to 'normal' size (Some MSN emoticons are *huge*). • Don't show at all (Maybe a question mark instead? Prehaps with the option for clicking on the questionmark and then make it show).

Replying to David Munch:

• Don't show at all (Maybe a question mark instead? Prehaps with the option for clicking on the questionmark and then make it show).

It doesn’t have to be a question mark: custom emoticons are mapped to some text strings and these text strings (like “: )” can be displayed instead of the actual emoticons).

Replying to cheungpat:

It doesn’t have to be a question mark: custom emoticons are mapped to some text strings and these text strings (like “: )” can be displayed instead of the actual emoticons).

Yes of course, how stupid of me. -.-

Anyway, it would be nice for them to be clickable, so the emoticons could be forced shown. Don't know how the smileys would be visually tagged though, so the user would know that there's a more visual alternative. But then again, one would assume that the user has preffered to see the text-smiley for some reason, and might not need this option at all.

Please disregard my last posts - Just realised this is about *sending* and not *recieving*. -.-

In fact libpurple's implementation is quite straightforward: I was able to test the feature adding 3 lines of code (+1 for each added emoticon actually) only. I took a look to Adium source code in the last few days and I have some ideas on how to implement the thing. It's quite simple in my mind and I bet the reality differs! I have to admit I don't have a full comprehension of how adium works, though. Anyway, the way I've thought is as follows: 1. Adium loads the emoticoncontroller, a lot of other stuffs, and then all the plugins (along with the libpurple's plugin); 2. When libpurple's plugin initializes itself it queries the emoticoncontroller to see which emoticonsets are enabled. Looping thru all the emoticons of the enabled sets (or somehow flagged to be "sending" emoticon sets) it loads all the "emoticon images/emoticon text" pairs calling purple_smiley_new_* (can be from file, or from an image buffer dunno which is better) This is enough to have a working sending emoticon feature that relies on libpurple. I feel like everything is already there and it's just waiting for some glue. Of course, I'm only putting my ideas here. I'd like to work on this thing even though I have few knowledge on how adium interfaces with libpurple and how the adium team "get things done".

We get things done by awesome people like yourself jumping in and working on things they are interested in :)

You've got a good start there. My biggest concern with your proposed implementation is that we'll be creating purple_smiley objects for every emoticon Adium has enabled, even though in the vast majority of situations those won't all be used (since while I type :) on a daily basis, I don't type :-*, for example), which is wasteful of memory and startup time.

Perhaps the emoticon controller could set some array on each AIContentMessage it processes, noting that the emoticons it contains (so that code later on wouldn't have to re-parse the string just to figure out what needs sending). Libpurple, upon seeing an outgoing message which (1) contains emoticons and (2) is on a service which supports sending emoticons would then check to see if the appropriate purple_smiley objects have already been made and, if not, make and set them before sending the message.

All this, of course, allows sending Adium emoticon packs' emoticons. A common MSN thing seems to be setting emoticons individually (rather than having an AdiumXtra author create the emoticons)... so a later step in your implementation might include a UI and code to handle this. However, I think worrying about that is putting the cart before the horse, as once the above is done, the latter shouldn't be too difficult.

Those are the exact kind of pointers I need to get going :) I still have some questions and doubts, but I don't wanna flood the trac with them.. is it possible to find you, or someone else with experience in adium's code, online for a chat? Irc or some IM would be fine..

Replying to duhanebel:

is it possible to find you, or someone else with experience in adium's code, online for a chat? Irc or some IM would be fine..

Thats exactly what the IRC channel is for: Irc.freenode.net #adium-devl

You can also find contact information here: AdiumDevelopers. To Success! ;)