Adium

Ticket #4161 (closed defect: fixed)

Opened 2 years ago

Last modified 3 months ago

Empty Jabber message body is displayed incorrectly

Reported by: delta407@lerfjhax.com Assigned to: am
Priority: normal Milestone: Adium X 1.2.5
Component: Jabber/XMPP Version: 1.2.4b2
Severity: minor Keywords:
Cc: Patch: None
Pending: 0

Description

Summary: Adium incorrectly displays a message conaining "<body/>" when an empty message is received. This may affect only empty-element tags -- that is, <body/> and not <body></body> -- however, both forms are defined to be equivalent.

Steps to reproduce: 1. Use Adium to connect to a Jabber server. 2. Have another Jabber user transmit the following:

<message xmlns='jabber:client' from='user@domain/resource' to='tester@domain/Adium'><body/></message>

Expected behavior: An empty message is displayed, visually identical to receipt of a message containing "<body> </body>".

Actual behavior: A message is displayed, visually identical to receipt of a message containing "<body>&lt;body/&gt;</body>".

Change History

08/07/2006 11:55:34 PM changed by edr1084

  • milestone set to Sometime after 1.0.

08/28/2006 06:38:59 AM changed by am

  • status changed from new to closed.
  • resolution set to fixed.

Doesn't occur in the Smack-based plugin, since it actually uses a proper XML parser.

05/04/2007 11:01:44 AM changed by arjenvr

This behaviour returned when Smack was dropped.

05/04/2007 12:44:55 PM changed by edr1084

  • status changed from closed to reopened.
  • patch_status set to None.
  • resolution deleted.
  • version changed from 0.89 to 1.1svn.
  • milestone changed from Good idea for "later" to Summer of Code 07.

03/15/2008 11:35:58 AM changed by jas8522

  • pending set to 1.
  • milestone changed from Summer of Code 07 to Needs feedback from users.

Does this still happen with 1.2.3 or the 1.2.4 AdiumBeta?

03/20/2008 06:15:51 AM changed by arjenvr

Able to reproduce this in 1.2.3. Adium displays '<body/>' when sending either an empty body tag (<body></body>) or a self-closing body tag (<body />).

03/20/2008 09:20:07 AM changed by jas8522

  • version changed from 1.1svn to 1.2.3.

Any change with 1.2.4b2? (AdiumBeta)

The libpurple update might be parsing this differently now - which is why I ask.

03/20/2008 09:52:01 AM changed by arjenvr

Still happens with 1.2.4b2

03/20/2008 09:56:18 AM changed by jas8522

  • owner changed from nobody to am.
  • status changed from reopened to new.
  • version changed from 1.2.3 to 1.2.4b2.
  • pending deleted.
  • milestone changed from Needs feedback from users to Adium X 1.2.5.

04/23/2008 08:36:41 PM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [23210]) Ignore /BODY tags when decoding HTML. Fixes #4161

04/23/2008 08:37:12 PM changed by evands

(In [23211]) Merged [23210]: Ignore /BODY tags when decoding HTML. Fixes #4161