Adium

Ticket #3647 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 months ago

Update default emoticon set for full MSN support

Reported by: www-adium@patrice.ch Assigned to: jas8522
Priority: low Milestone: Adium 1.3
Component: Xtras Version:
Severity: trivial Keywords:
Cc: beej Patch: Accepted
Pending: 0

Description

Adium ships with a incomplete set of MSN emoticons. The full list (I hope) is documented by Microsoft at http://messenger.msn.com/Resource/Emoticons.aspx

Attachments

Emoticon Sets.zip (0.8 MB) - added by jas8522 on 05/22/2008 09:16:15 PM.
Updated emoticon sets
Default.AdiumEmoticonset.zip (311.5 kB) - added by jas8522 on 05/24/2008 08:06:28 AM.
This should be all of them updated for the default set!
MSN.AdiumEmoticonset.2.zip (281.6 kB) - added by jas8522 on 05/27/2008 09:51:50 AM.
MSN.AdiumEmoticonset.zip (281.6 kB) - added by jas8522 on 05/27/2008 09:53:58 AM.
Default.AdiumEmoticonset.2.zip (154.2 kB) - added by jas8522 on 05/30/2008 06:40:52 PM.
Here's an updated default set that includes all the smileys and a few additional ones that people seem to use regularly.
eye-rolling-fix.diff (0.8 kB) - added by jas8522 on 06/04/2008 07:21:04 AM.
This patch should fix the eye rolling icon not working for 8-)
MSN.AdiumEmoticonset.3.zip (323.7 kB) - added by jas8522 on 06/04/2008 07:39:52 AM.
Fixes animating icons not animating, and includes the eye-rolling fix I just attached. Also removes an icon that wasn't being used!
Emoticon sets DONE.zip (0.6 MB) - added by enkuturi on 06/19/2008 10:32:11 PM.
The latest emoticons i Did. Contains Default and MSN

Change History

08/03/2006 03:05:02 PM changed by edr1084

  • component changed from MSN to Xtras.
  • milestone set to Sometime after 1.0.

01/02/2008 06:26:16 PM changed by djmori

This could be fixed, making a xtra (like #851 or #1) the default msn emoticon pack in adium

01/02/2008 10:39:57 PM changed by jas8522

  • version changed from 0.89 to 1.2svn.
  • patch_status set to None.
  • summary changed from MSN Emoticons set incomplete to Emoticons set incomplete for MSN.
  • pending changed.
  • milestone changed from Good idea for "later" to Adium X 1.3.

This AdiuMSN Set is done Adium emoticon style but includes all the ones needed for full emoticon support for MSN. We should consider requesting permission for that for this release for better MSN support.

01/02/2008 10:43:15 PM changed by djmori

The Adiumized MSN custom emotes set, is an updated version of AdiuMSN. If we want the most complete version available, I think this is the one.

03/10/2008 02:45:12 PM changed by jas8522

  • priority changed from normal to low.
  • version deleted.
  • type changed from defect to enhancement.
  • severity changed from normal to trivial.
  • summary changed from Emoticons set incomplete for MSN to Update default emoticon set for full MSN support.

I think if we update to the Adiumized MSN set suggested by djmori we should remove some of them from the pack. It does indeed cover almost all of the ones built in to Windows Live Messenger, but it also has extras that can be rather annoying.

03/31/2008 09:59:40 PM changed by jas8522

I have contacted the author to request that he make an adjusted set to be included in Adium or allow me to adjust them so we can take care of this for 1.3.

For reference, here is the list of MSN Emoticons that should be matched by these - no more, no less:

http://messenger.msn.com/Resource/Emoticons.aspx

04/03/2008 11:18:15 AM changed by beej

cc me

04/05/2008 04:57:08 AM changed by djmori

  • cc set to beej.

04/29/2008 11:59:08 AM changed by jas8522

At the moment, I've got two sets almost ready to go:

  1. A set to replace the "Default" emoticon set. The objective here is to have support for all the Adium-style emoticons, plus all of the MSN set. In such a way, new users to Adium that are primarily using it for MSN will have all the common emoticons right off the bat.
  2. A replacement set for the MSN emoticon set. In this case all the smiley faces are identical to the Windows Live Messenger emoticons, except now it includes all of the additional ones, like airplane, xbox, etc.

The only thing left to do with them is clean up the edges so they look OK on dark backgrounds. I'm working with Bastian Olea to get this done in the next couple weeks.

05/02/2008 11:20:25 AM changed by jas8522

  • owner changed from nobody to jas8522.
  • status changed from new to assigned.

05/15/2008 08:38:23 AM changed by djmori

05/22/2008 09:08:31 PM changed by evands

How's it coming? :)

05/22/2008 09:15:25 PM changed by jas8522

There are still some with some rough edges, but at least the majority of common emoticons (such as the smileys) are well cleaned up. I'm attaching them as they currently exist, which should be ok to merge for 1.3. I will still be working on cleaning the remaining ones up a bit, and will open another ticket when I get it all completed so they can be added to the nearest release at that time.

05/22/2008 09:16:15 PM changed by jas8522

  • attachment Emoticon Sets.zip added.

Updated emoticon sets

05/24/2008 08:06:28 AM changed by jas8522

  • attachment Default.AdiumEmoticonset.zip added.

This should be all of them updated for the default set!

05/27/2008 09:51:50 AM changed by jas8522

  • attachment MSN.AdiumEmoticonset.2.zip added.

05/27/2008 09:53:58 AM changed by jas8522

  • attachment MSN.AdiumEmoticonset.zip added.

05/27/2008 09:54:21 AM changed by jas8522

Dammit... forgot to check the box (you can ignore the one with the .2 on it)

05/29/2008 05:09:25 PM changed by evands

Woah. I'm not down with this giant default set. The vast majority of people who use emoticons use somewhere between 5 and 15 in my experience. I don't want to present an off-the-screen emoticon menu by default.

Furthermore, most of our users will be talking to people who won't have any clue what the textual versions of these mean. (li) means Lightning but (l) means Lightbulb? It's nonsense!

05/30/2008 06:37:14 AM changed by jas8522

I had a feeling that would be the case - we can always post that set to the xtras site - the primary objective of this ticket from the start was to replace the MSN set - the default set would have just been a bonus for those coming from Windows Live Messenger or Messenger for Mac to have it enabled automatically.

Nonetheless, the only reason the sets are nearly unmanageably large is because of our list view - if that gets changed to a grid, then it's really rather simple for users to manage.

So if you're OK with the replacement MSN set (as that *is* the current set available in the mainline clients) then you can merge that and call this fixed.

05/30/2008 06:42:10 AM changed by jas8522

Actually on second thought, there are still a few smileys that could be of benefit for the actual default set. Let me strip out the extras (such as those wrapped in parentheses) and leave it with just smileys, then I can merge the sets... I think that would be more reasonable. (So we can have emoticons like :| for example)

05/30/2008 06:40:52 PM changed by jas8522

  • attachment Default.AdiumEmoticonset.2.zip added.

Here's an updated default set that includes all the smileys and a few additional ones that people seem to use regularly.

05/31/2008 09:14:07 AM changed by evands

(In [23771]) out with the old MSN emoticon set. Refs #3647

05/31/2008 09:16:38 AM changed by evands

(In [23772]) In with the new, complete MSN emoticon set. Refs #3647

05/31/2008 09:23:14 AM changed by evands

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [23773]) Expanded default emoticon set from jas8522. Closes #3647

06/04/2008 07:03:08 AM changed by Dimmuxx

:'( :) <:o) () still aren't animated like they should be.

06/04/2008 07:08:36 AM changed by Dimmuxx

8-) is also wrong and there might be some more that's still not the normal msn ones so I report them when/if I find them.

06/04/2008 07:21:04 AM changed by jas8522

  • attachment eye-rolling-fix.diff added.

This patch should fix the eye rolling icon not working for 8-)

06/04/2008 07:39:52 AM changed by jas8522

  • attachment MSN.AdiumEmoticonset.3.zip added.

Fixes animating icons not animating, and includes the eye-rolling fix I just attached. Also removes an icon that wasn't being used!

06/04/2008 07:40:19 AM changed by jas8522

  • status changed from closed to reopened.
  • patch_status changed from None to OK; Needs Check-In.
  • resolution deleted.

06/04/2008 08:16:52 AM changed by evands

Which icon isn't being used?

06/04/2008 08:27:12 AM changed by jas8522

There was a png and a gif of the icon... I just don't recall which one is was now. I think we were using the gif, which is right due to the animations, and making the png unnecessary.

06/04/2008 10:27:57 PM changed by evands

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [23803]) Further fixes for MSN emoticons. Fixes #3647. Good work :)

06/19/2008 10:31:12 PM changed by enkuturi

Sorry for the time i took making this. I think these are almost done, but if any one have any improvement feel free to ask me :D Here are the files, please add them to the latest beta.

06/19/2008 10:32:11 PM changed by enkuturi

  • attachment Emoticon sets DONE.zip added.

The latest emoticons i Did. Contains Default and MSN

06/19/2008 10:38:39 PM changed by jas8522

  • status changed from closed to reopened.
  • resolution deleted.

For the record, enkuturi is where they were coming from - I was just relaying them here. While I cleaned up a few of them, he re-did the ones that I did in a rush ;) so these should look better. I asked him to grab the ones from 1.3b3 and overwrite the new ones on top of that, so that the changes we made remain the same.

06/19/2008 11:09:16 PM changed by jas8522

  • status changed from reopened to closed.
  • resolution set to fixed.

To clean up this ticket, I created a new one at #10182

I'll put this one down for good :P

08/02/2008 08:32:14 PM changed by Robby

  • patch_status changed from OK; Needs Check-In to Accepted.

09/10/2008 04:07:48 PM changed by earthling

I'd like to add in a vote for the :| emoticon. Should I create a new ticket for that?

09/10/2008 04:33:11 PM changed by jas8522

earthling: that one is already in the default set for me... I use it constantly! Are you sure it's not working with the default set selected in 1.3 or greater?

09/11/2008 02:13:03 PM changed by earthling

Sorry -- that one is fine! The one I meant to request is the :T emoticon. I'm not sure if it's in the MSN set (Trillian has it), but it's another one I use constantly, so I wanted to at least cast a vote for it...

thanks for the response

09/11/2008 02:55:47 PM changed by jas8522

As far as I can tell that is only implemented in Trillian - none of the primary messenger protocols. Therefore it's unlikely to be put in the default emoticon set, however you're more than welcome to create an emoticon set that uses it, or check out the sets on the Xtras site as one of them may already contain it.

09/11/2008 02:55:54 PM changed by jas8522

  • milestone deleted.

09/11/2008 02:56:17 PM changed by jas8522

  • milestone set to Adium X 1.3.

Thought this was a new ticket for a second... back to 1.3 you go.

09/11/2008 03:13:41 PM changed by earthling

Thanks for the suggestion. The problem with that is that the number of people who use a custom emoticon set will be very small; much smaller than the general Adium user base. Hope you will reconsider sometime in the future.

09/11/2008 04:25:55 PM changed by Robby

So you'd like us to force an emoticon that is only used in Trillian on the broad userbase?