Adium

Ticket #2300 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Arrows in File Transfer Window require the AppleGothic font

Reported by: boredzo Assigned to: boredzo
Priority: normal Milestone: Adium X 1.0
Component: Adium UI Version: 0.86
Severity: blocker Keywords: ESFileTransfer FileTransfer file transfer AppleGothic Apple Gothic font crash starter
Cc: Patch:
Pending:

Description (Last modified by evands)

Currently, the arrows require the AppleGothic font, which is installed with the system but may be uninstalled. Fix: draw the arrows ourselves.

Change History

11/30/2005 07:21:48 AM changed by evands

Already fixed the crash in HEAD and adium-0.8 HEAD [we don't draw the arrow if Apple Gothic can't be found]... The font comes with the system... but if you want to rewrite the arrow drawing to be done ourselves, go for it :)

11/30/2005 07:22:00 AM changed by evands

  • milestone deleted.

11/30/2005 07:22:19 AM changed by evands

  • summary changed from File transfers require the AppleGothic font to Arrows in File Transfer Window require the AppleGothic font.

11/30/2005 07:23:08 AM changed by boredzo

the user apparently deleted the font. not unreasonable; it isn't one of the core system fonts.

11/30/2005 07:50:26 PM changed by boredzo

  • status changed from new to closed.
  • resolution set to fixed.

(In [14254]) We no longer use AppleGothic to draw the arrow badges on icons in the File Transfers window. Instead, we draw the arrow ourselves. Fixes #2300.

11/30/2005 07:58:49 PM changed by boredzo

(In [14255]) We no longer use AppleGothic to draw the arrow badges on icons in the File Transfers window. Instead, we draw the arrow ourselves. Fixes #2300.

11/30/2005 08:05:35 PM changed by catfish_man

  • milestone set to Adium X 0.87.

11/30/2005 08:36:45 PM changed by evands

I think [14255] missed merging the arrowPathInSize:pointingDown: method.

11/30/2005 08:36:55 PM changed by anonymous

  • status changed from closed to reopened.
  • resolution deleted.

12/02/2005 12:27:21 AM changed by tick

  • severity changed from normal to blocker.

This blocks on .87

12/02/2005 01:22:08 AM changed by boredzo

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [14275]) Forgot to merge -arrowPathInSize:pointingDown:. Oops. Fixes #2300 (again).

12/12/2005 07:14:36 PM changed by evands

  • status changed from closed to reopened.
  • resolution deleted.

The arrow as drawn as of [14275] is too fat; the AppleGothic arrow makes a good template for how it should look.

12/14/2005 04:44:50 PM changed by evands

  • milestone changed from Adium X 0.87 to Adium X 1.0.

Moving this ticket to no longer require AppleGothic for the file transfer arrow overlay to 1.0 Milestone.

12/14/2005 04:45:25 PM changed by evands

  • description changed.

12/14/2005 04:46:37 PM changed by evands

(In [14420]) Reverted ESFileTransfer in adium-0.8 to [14253]; we simply won't draw the arrow if AppleGothic isn't installed. We can fix this more 'properly' with an equally-attractive arrow for 1.0.

Refs #2300.

01/06/2006 08:12:12 PM changed by catfish_man

  • keywords changed from ESFileTransfer FileTransfer file transfer AppleGothic Apple Gothic font crash to ESFileTransfer FileTransfer file transfer AppleGothic Apple Gothic font crash starter.

This seems like it should be easy enough to fix. Just look at the code that was reverted and tweak until it looks right.

01/08/2006 07:44:24 PM changed by boredzo

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [14837]) Got the arrow drawing correctly in both directions. Fixes #2300.

01/09/2006 05:05:26 PM changed by boredzo

(In [14851]) Moved arrow-path code to AIBezierPathAdditions, and genericised it by splitting it into (1) create an arrow path (2) flip it (3) resize it. Refs #2300. Added marks in AIBezierPathAdditions.