Adium

Ticket #2262 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Text Cursors in the Text Fields are not pleasant in invert

Reported by: Assigned to: nobody
Priority: low Milestone: Adium X 1.0
Component: Adium UI Version:
Severity: normal Keywords:
Cc: Patch:
Pending:

Description

The color of the text cursor should be the inverted color of the background color of the text field. (It's practically impossible to see the text cursor when the bg color is black)

Attachments

invertedColor.diff (2.8 kB) - added by freakman on 02/27/2006 04:25:06 PM.
TEH HOLY PATCH (the new one)
contrastingColor.diff (2.9 kB) - added by freakman on 02/27/2006 04:43:52 PM.
The newest one

Change History

11/28/2005 11:28:20 PM changed by tick

  • milestone set to Adium X 1.0.

12/06/2005 02:44:44 PM changed by evands

  • milestone deleted.

This is technically an Apple bug... we can fix it in one of our custom subclasses most likely.

12/08/2005 08:35:12 AM changed by zacw

  • summary changed from Text Cursors in the Text Fields are teh suck to Text Cursors in the Text Fields are not pleasant in invert.
  • reporter deleted.

02/16/2006 07:51:00 PM changed by tick

  • milestone set to Sometime after 1.0.

02/26/2006 03:35:15 PM changed by freakman

This might work: 

[self setInsertionPointColor:[NSColor colorWithCalibratedRed:1.0f - [backgroundColor redComponent] green:1.0f - [backgroundColor greenComponent] blue:1.0f - [backgroundColor blueComponent] alpha:1.0f]];

02/26/2006 06:20:04 PM changed by catfish_man

  • status changed from new to closed.
  • resolution set to fixed.

(In [15375]) Patch from freakman. Fixes #2262

02/26/2006 06:20:35 PM changed by catfish_man

  • milestone changed from Sometime after 1.0 to Adium X 1.0.

02/26/2006 07:43:51 PM changed by boredzo

  • status changed from closed to reopened.
  • resolution deleted.

as kbotc mentions, this is no good when the background color is 50% gray. perhaps we should use the text color instead?

02/26/2006 09:49:51 PM changed by evands

There's an AIColorAdditions method which is probably right for this -- colorByAdjustingForBackground: or something like that is the name IIRC.

02/27/2006 04:25:06 PM changed by freakman

  • attachment invertedColor.diff added.

TEH HOLY PATCH (the new one)

02/27/2006 04:43:52 PM changed by freakman

  • attachment contrastingColor.diff added.

The newest one

02/27/2006 05:10:12 PM changed by catfish_man

  • status changed from reopened to closed.
  • resolution set to fixed.

Should be fixed now.