Adium

Ticket #2178 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Plug-ins installed into the wrong directory on HFSX partitions.

Reported by: anonymous Assigned to: tick
Priority: normal Milestone: Adium X 1.0
Component: Adium Core Version: 0.86
Severity: minor Keywords: HFSX, case sensitive
Cc: Patch:
Pending:

Description

If you are using a case sensitive filesystem such as HFSX installing plugins fails. The plugin is placed in "~/Application Support/Adium 2.0/Plugins/". But Adium does not detect plugins in this directory, Adium gets its plugins from "~/Application Support/Adium 2.0/PlugIns/" which is another directory on a case sensitive FS.

Change History

11/12/2005 07:12:43 PM changed by zacw

This is one of many, many problems associated with case-sensitiveness, including Xtras that do not work properly.

11/12/2005 07:16:46 PM changed by tick

  • milestone set to Adium X 1.0.

11/12/2005 08:15:57 PM changed by tick

Hopefully resolved with #14008

11/12/2005 08:16:10 PM changed by tick

Bah, [14008] was that.

11/12/2005 08:16:18 PM changed by tick

  • status changed from new to closed.
  • resolution set to fixed.

11/13/2005 04:18:26 AM changed by anonymous

  • status changed from closed to reopened.
  • resolution deleted.

That didn't actually fix it. The directory should still be called "PlugIns" because this is where the Copy Files phase puts the internal plugins. The real problem is in AIAdium.m: 

        destination = [ADIUM_APPLICATION_SUPPORT_DIRECTORY stringByAppendingPathComponent:@"Plugins"];

It should use @"PlugIns" there. Furthermore, the installation directory of the SQL Logger should be changed from "/Adium.app/Contents/Plugins/" to "/Adium.app/Contents/PlugIns/".

11/13/2005 04:24:52 AM changed by tick

So right now everything is set to Plugins, and you want us to change it to PlugIns? I'd rather keep it as Plugins if that's how it all is right now. If not I'll change AIAdium.m to be Plugins in the morning.

11/13/2005 04:25:11 AM changed by tick

  • owner changed from nobody to tick.
  • status changed from reopened to new.

Bah, trac is being evil

11/13/2005 04:25:29 AM changed by tick

  • status changed from new to assigned.

11/20/2005 05:24:31 AM changed by catfish_man

unfortunately the name of the in-bundle plugins directory appears to be dictated to us by the system... we may have to rename the external one to PlugIns.

12/04/2005 02:55:39 AM changed by dreamind@dreamind.de

Well if Plugins should be used, then the remaining thing which needs to be fixed is Frameworks/Adium Framework/AIPathUtilities.m.

12/04/2005 02:57:08 AM changed by boredzo

dreamind: it shouldn't.

12/04/2005 02:57:38 AM changed by boredzo

  • summary changed from Plug-ins installed ito the wrong directory on HFSX partitions. to Plug-ins installed into the wrong directory on HFSX partitions..

Judge Lance Ito is not relevant to this ticket.

12/04/2005 03:55:40 AM changed by boredzo

I just tested with a case-sensitive (HFSX) disk image. Finder looks for 'PlugIns', so that is what the internal plug-ins folder must be named. we're free to name the external folders whatever we want, though.

12/15/2005 12:05:16 AM changed by evands

  • status changed from assigned to closed.
  • resolution set to fixed.

This is fixed in 1.0svn.

03/17/2006 04:00:30 PM changed by anonymous

  • status changed from closed to reopened.
  • resolution deleted.

This is still an issue. I don't know what changed or when (well I know that it happened approximately a month ago in SVN). I do know how to fix it:... all that has to be done is to change the line in AICorPluginLoader.m

#define DIRECTORY_INTERNAL_PLUGINS [@"Contents" stringByAppendingPathComponent:@"Plugins"]

to

#define DIRECTORY_INTERNAL_PLUGINS [@"Contents" stringByAppendingPathComponent:@"PlugIns"]

03/21/2006 01:25:12 AM changed by evands

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [15532]) s/Plugins/PlugIns so our directory names are case consistent, fixing problems on case sensitive file systems. Fixes #2178