Adium

Ticket #11323 (new defect)

Opened 2 months ago

Last modified 2 months ago

Style Markup is Not Processed When Coming From iChat

Reported by: Sastira Assigned to:
Priority: normal Milestone: Adium 1.4
Component: Message View Version: 1.3.2
Severity: normal Keywords: style
Cc: Patch: Needs Dev Review
Pending: 0

Description

iChat uses CSS markup to denote style and font changes in messages, as opposed to tags. Adium currently does not support or does not properly process CSS styles.

XML Console output shows this when receiving text from iChat:

<message xmlns='jabber:client' to='sastira@gmail.com/AdiumE2496988' type='chat' id='iChat_39EBC8CC' from='jxxxxx@gmail.com/Apophis58DF4D67'> <body>How about inline styles in addition to something in code?</body> <html xmlns='http://jabber.org/protocol/xhtml-im'><body xmlns='http://www.w3.org/1999/xhtml' style='background-color:#C0E668;color:#000000'><span style='font-size:12px; font-family:Helvetica; '>How about <span style='font-weight:bold'>inline</span> styles <span style='font-style:italic'>in addition to</span> </span><span style='font-size:11px; font-family:Monaco; '>something <span style='color:#A90E93'>in</span> code?</span></body></html>

And this when sending text back out:

<message type='chat' id='purple12254289' to='jxxxxxx@gmail.com/Apophis58DF4D67'>

<active xmlns='http://jabber.org/protocol/chatstates'/> <body>How about some italics and a bit of bold?</body> <html xmlns='http://jabber.org/protocol/xhtml-im'>

<body xmlns='http://www.w3.org/1999/xhtml'>How about <em>some italics</em> and a <span style='font-weight: bold;'>bit of bold</span>?</body>

</html>

</message>

Attachments

stylePatch.diff (12.3 kB) - added by Sastira on 11/01/2008 09:48:00 PM.

Change History

11/01/2008 09:48:00 PM changed by Sastira

  • attachment stylePatch.diff added.

11/01/2008 09:49:26 PM changed by Sastira

My friend and I have worked on this and everything seems to be working fine. Please find attached a diff containing our changes for review.

11/02/2008 03:53:10 PM changed by Robby

  • patch_status changed from None to Needs Dev Review.

11/09/2008 12:53:33 PM changed by zacw

  • milestone set to Adium 1.4.

Let's take a look at this for 1.4.