Block Contact Toolbar Icon

Duplicate of #1100 (though #1100 is worded strangely).

The summary really shouldn't be a question. Also, I should note that #1100 was marked as a duplicate of this due to its confusing description.

I'm working on ticket #344 and I'll be able to implement something like this as well if you'd like. I know some IM users that would appreciate a feature like this. If you need to contact me, kgilla10@scu.edu.au is my email address.

Ok, how does this sound:
1) Message Window block button: allows the user to block/unblock the buddy the user has the conversation window open for.
2) Contact List block button: allows the user to block/unblock selected contact(s) on the contact list. If some of the selected contacts are already blocked, only those that are unblocked will be blocked. The proposed plugin will only unblock a group of selected contacts who are all blocked.

If the above proposed ideas are kosher with the devs and with the closure of ticket 344 at hand, privacy in Adium should turn out pretty nicely for users in 1.0.

Kiel, that sounds like good behavior to me. Contact->Block / Contact->Unblock should behave as you describe in (2) above, since it could be called with multiple contact list items selected.

Evan, isn't that the way that menu behaves now? If not, it should. My only comment about 2) is that it seems to say that unblocking a group of contacts that have a heterogeneous state (i.e. some are blocked, some are not) would be a no-op or display an error; I think that's silly. If they are already unblocked, awesome! Less work for the code to do ;-)

Allow me to clarify:

1. If some of the selected contacts are blocked, only those that are not blocked will be blocked. So at the end of the operation, all the selected contacts will be blocked. With visual notification of blocked contacts, users will be able to clearly see that all the selected contacts are blocked.
2. Unblocking only occurs when all the selected contacts are blocked.

None of the menus allow the user to block/unblock multiple contacts at the same time.

please tell me how I can unblock a buddy. thanks!

samomo6485: Trac tickets are not for support requests. you should go to the forums and ask your question there.

The same way you blocked your buddy. Choose the contact in the contact list and control click and choose Unblock or choose Contact > Unblock from the menu bar.

I don't understand why this is hard/confusing for people to find or do...

I think the source of the confusion is that blocked buddies seem to go offline, so they disappear. fortunately, we have a menu item command for that.

Can someone please tell me why the toolbar item isn't executing the action when ?

I have no problems blocking and unblocking contacts when there's a visible icon in the toolbar, but when it's just a textual representation of the toolbar item, the action is not even called.

To reproduce, apply the patch, add the block icon to your message view toolbar, command-click the show/hide toolbar widget in the message view's title bar until the toolbar items are represented as text only and attempt to block/unblock a contact.

It has me stumped.

Blasted patch

Take 2:

Can someone please tell me why the toolbar item isn't executing the action assigned to it when the toolbar item is shown in text only mode?

I have no problems blocking and unblocking contacts when there's a visible icon in the toolbar, but when it's just a textual representation of the toolbar item, the action is not even called.

To reproduce, apply the patch, add the block icon to your message view toolbar, command-click the show/hide toolbar widget in the message view's title bar until the toolbar items are represented as text only and attempt to block/unblock a contact.

It has me stumped.

Same patch riddled with NSLogs

In [15593], fixed a bug that solves the problem I was having with this patch. Will commit a patch to address this ticket in a week if I don't hear any complaints about the changes made in [15593].

While I haven't noticed any problems with [15593] yet, I'm left scratching my head as to why such a huge block of code was written if the copy method actually works as promised ;)

If this is going in, feel free to move it back. If not, we're not gonna block on it.

It's going in.

(In [15618]) Providing a Block/Unblock toolbar item for message windows. Closes 1117.

World of Warcraft gold(wow gold)--buy cheap,sell wow goldwelcome to buy cheap --cheap, easy, purchasing.World of Warcraft,Super fastdelivery of gold, items,and accounts

China's first cartoon play Dreamland will debut on Children's Day 2006. The play will be produced by CCTV's children's channel and promoted by the China Perfoming Arts Agency(wow gold), perhaps best known as the Chinese agent for Disney on Ice during the past two years.come on Over the last 20 years, CCTV has always presented a variety show on June 1, the No.1 TV programme on that day. Aiming to produce China's grandest cartoon play, CCTV and other eight governmental organs called on world of warcraft gold China's best producers, dirctors, please come on actors and actresses and stage technicians to help create this marvel.

Replying to victor.andree@gmail.com:

I really think there should be a "Block/Unblock contact"-icon in the IM-window toolbar.

I really think you should check your facts before you reopen tickets.