Hebrew shows up wrong on styles since 1.3

Hebrew style issue on Renkoo

Hebrew style issue on Mockie

Here's a string in hebrew for you people to play with while you're testing this out: שורה בשפה העברית

MacOS should automatically RLT it.

I can confirm this problem in renkoo.

In mockie the right-padding issue is present in LtR languages, and can be seen by sending something a long series of "1 " and then resizing the window until just before a "1" wraps. The unwrapped one will sit right against the timestamp.

I do not see the one char alignment issue.

Gone Dark has the same problem as Mockie.

Stockholm's right timestamp-on-hover forces a strange-looking right intent in the RtL text.

Minimal-Mod doesn't right justify RtL text. Technically it should, but it certainly can call on artistic license to not do so. :)

I also see the newline problem in two of my own messagestyles. I'll try to patch the builtins once I figure out the problems for my own.

ugh, this is what happens when I have only 4 hours sleep.

Since this fine in 1.3, it probably really is a message view problem. Though the essages style might benefit from some tweaking too.

mathuaerknedam: So what's the solution?

Replying to evands:

mathuaerknedam: So what's the solution?

To be honest, I forgot about it. I can patch Mockie and Gone dark easily enough, it's just a matter of adding a bit of padding. I've not looked into the newline yet, it may also be easy. I'll bookmark this ticket so that I remember to look at it again soon.

However, the fact that they worked fine before 1.3 makes me hesitant to simply bandaid the message styles symptom without knowing what in the message view caused the problem in the first place.

The problem in Renkoo is probably that it has a pretty inflexible structure (explicit HTML tables) and the insertion of <div dir="rtl"> around the text breaks the structure, causing a new line (expected behavior for a div). Since the pattern is so regular (div[dir=rtl]), it is easy overcome the newline in CSS. However, I've not yet found a way to do so without making the RTL text aligned to the left.

Winterk, Can you post screenshots of how this looks in 1.2.7? I should probably use that as a visual reference for any message style patches (if we go that route).

Could we use something besides a div to set the direction without inserting the newline which is problematic in some styles?

It's been long enough since I looked at this that I don't remember everything, but if I remember correctly, spans didn't break message styles, but then RtL wasn't reliable. I wasn't able to come up with any satisfactory solution, so I'm really curious how it worked in 1.2.7 and if we can somehow revert to that treatment without losing the desired effect of the relevant code change.

Replying to mathuaerknedam:

if I remember correctly, spans didn't break message styles

This would make sense since div tags are block level, thus causing everything around it to be above and below. Spans are inline so should accomplish the same effect without the appearance of a new line after it.

Replying to jas8522:

This would make sense since div tags are block level, thus causing everything around it to be above and below. Spans are inline so should accomplish the same effect without the appearance of a new line after it.

Hm, I guess I was unclear. replacing the div with a span didn't break the message style, but it also didn't make the text flush-right. I just tested by taking a chat correctly displaying RtL text and replacing the "<div dir=rtl></div>" with "<span dir=rtl></span>". The text that had been (correctly) aligned to the right became (incorrectly) aligned to the left.