Adium

Ticket #10436 (closed defect: fixed)

Opened 6 months ago

Last modified 2 weeks ago

Events can be recorded with wrong contact

Reported by: sightless Assigned to: eharris
Priority: normal Milestone: Adium 1.3.3
Component: Contact Inspector Version:
Severity: normal Keywords:
Cc: Patch: None
Pending: 0

Description 

To reproduce:
- Right click a contact in your contact list; Get Info.
- Go to the events tab.
- Click the + button to add an event.
- While the 'add event' sheet is still open, select a different contact
  in your list; the "When <username> <does whatever>" part of the sheet
  remains the same, though the title bar of the info window changes to
  reflect the newly selected contact.
- Finish filling out the add event sheet and click OK. The event is added
  to the newly selected contact, not to the one you clicked + for.

I personally would like to have multiple Get Info windows rather than an
Inspector-like thing, which would solve this problem (except if an Inspector is
still offered, like how the Finder offers both, this would need to be special
cased).

But that's really a feature request, and this is a bug report. I'm not sure of
the best way to get around this in the Inspector situation like Adium currently
has. It would be equally odd to have an event added not appear in the window
(because it is showing a different contact) or to have the window showing a
different contact to that which is selected in the contact list. And making the
add event sheet a modal dialog would be horrible.

I guess one of you guys will pick the best of the bad bunch and implement it! Good luck, and thanks for a great app.

Adium version 1.2.7 on OS X 10.4.9.

Change History

07/12/2008 06:42:34 AM changed by jas8522

  • milestone set to Adium X 1.3.1.

Multiple info windows is anti-inspector-like, so that likely won't be done. Having open sheets with [contact] details update based on the selected contact is the correct behaviour here, so if we can do that, then it's likely the best solution.

(follow-ups: ↓ 3 ↓ 6 ) 08/26/2008 01:01:37 PM changed by eharris

  • owner set to eharris.
  • status changed from new to assigned.

This is a pretty insane use case for any piece of software. Changing contacts in the middle of event creation does not merit a special workflow to handle. A request for multiple inspectors is valid (since that does occur in other applications). In this situation however, as soon as you click on another contact, the correct behavior is to cancel the event creation.

It's valid to want to have multiple inspectors, but I don't really see the need, perhaps you can justify your reason for me?

(in reply to: ↑ 2 ) 08/26/2008 03:06:34 PM changed by jas8522

Replying to eharris:

This is a pretty insane use case for any piece of software. Changing contacts in the middle of event creation does not merit a special workflow to handle. A request for multiple inspectors is valid (since that does occur in other applications). In this situation however, as soon as you click on another contact, the correct behavior is to cancel the event creation.

Yes this is what I was thinking as well.

09/02/2008 09:05:06 PM changed by jas8522

  • milestone changed from Adium 1.3.1 to Adium 1.3.2.

09/02/2008 09:05:17 PM changed by jas8522

  • milestone changed from Adium 1.3.2 to Adium 1.3.3.

(in reply to: ↑ 2 ) 09/07/2008 03:45:00 AM changed by sightless

Replying to eharris:

This is a pretty insane use case for any piece of software. Changing contacts in the middle of event creation does not merit a special workflow to handle. A request for multiple inspectors is valid (since that does occur in other applications). In this situation however, as soon as you click on another contact, the correct behavior is to cancel the event creation.

I fail to see how the use case is insane. Doing only a single task at a time with a computer takes us back 20 years just in Macintosh history. If you think this is insane, though, the correct solution is most certainly to make the add event dialog modal, not to cancel the event creation (which would lose any, perhaps carefully-crafted, text you had entered in the window, which amounts to data loss which is BAD).

It's valid to want to have multiple inspectors, but I don't really see the need, perhaps you can justify your reason for me?

I'd find it handy to be able to see and edit notes from more than one contact on the screen at a time, etc. Updating notes over an extended period as a conversation progresses can be useful, and it's easier to click a window to bring it to the front than to find the contact in the list and select it when it's needed.

Similarly, I'll often dig through my offline contacts to find someone and open an info window for them, or quickly click them just as they go offline. It would be handy if I could leave that open to come back to it after conversing with others, rather than needing to find it again every time I click a different contact.

Ben.

12/28/2008 08:44:07 AM changed by evands

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [25704])

  • When the contact being shown in the contact inspector changes, dismiss any existing add or edit contact alert sheet. Fixes #10436 *?\194?\160Cleanup and document the public creator for CSNewContactAlertWindowController

12/28/2008 09:11:57 AM changed by evands

(In [25706]) Merged [25704]:

  • When the contact being shown in the contact inspector changes, dismiss any existing add or edit contact alert sheet. Fixes #10436 *?\194?\160Cleanup and document the public creator for CSNewContactAlertWindowController