Adium

Ticket #10255 (closed defect: fixed)

Opened 5 months ago

Last modified 4 months ago

Sorting contacts very difficult

Reported by: Robby Assigned to:
Priority: highest Milestone: SVN issues
Component: MetaContact Version: 1.3svn
Severity: blocker Keywords:
Cc: Patch: None
Pending: 0

Description

[24101]
It seems sorting contacts is saved nicely now but a problem I have been seeing for quite a while now (probably ever since editing of combined contacts in the contact list was implemented) is that it's quite impossible to sort a contact below a combined contact.

While holding on to a contact and hovering over the list the bar does appear. But nevertheless when I let go Adium asks whether I want to combine.

Could this be related to #10254?

Attachments

Configure Status Sort.png (54.7 kB) - added by Robby on 07/13/2008 04:31:50 PM.

Change History

06/29/2008 06:51:54 PM changed by Robby

  • summary changed from Sorting contacts very difficult, Adium wants to combine contacts all the time to Sorting contacts very difficult.

(follow-up: ↓ 5 ) 06/29/2008 07:15:40 PM changed by jas8522

I think this is the same problem as #10257 ... albeit a different incarnation of it (we just need to abstract the understanding of it slightly). Here's why:

What is actually happening here for me is best described as steps to reproduce:

  1. Drag a contact directly below a metacontact that is expanded (if it's collapsed, there is no problem - it works as expected)
  2. Notice the drop bar indicator appears (seemingly) where it should - between the last subcontact of the metacontact and the next contact in the list.
  3. When you actually drop the contact, it behaves like you're just dropping it in the group, and not specifying position, which is why it does not sort properly.

In #10257 dropping a contact to the last position in a group drops it in the first group in the list. Think of the metacontact as the group, and the parent group (that the metacontact belongs in) as the entire contact list, then we're reproducing the same thing as #10257 describes - attempting to drop a contact into the last position of a group (in this case a metacontact), and it's actually getting placed in the first group of the list (in this case, the parent group).

Hopefully that makes sense to someone other than me... :P

06/30/2008 10:43:55 AM changed by jas8522

After updating to [24109] which includes the fix for #10257, I no longer have any problems with this (ie: I cannot reproduce the problem in this ticket) as long as my list is configured for manual sort.

Fixed for you Robby?

06/30/2008 12:52:06 PM changed by Robby

No, not in the slightest. :(

(in reply to: ↑ 2 ) 06/30/2008 01:24:16 PM changed by Robby

Replying to jas8522:

1. Drag a contact directly below a metacontact that is expanded (if it's collapsed, there is no problem - it works as expected)
2. Notice the drop bar indicator appears (seemingly) where it should - between the last subcontact of the metacontact and the next contact in the list.

3. When you actually drop the contact, it behaves like you're just dropping it in the combined contact.

That's my issue!

This happens no matter whether I wait for the combined contact to expand while I hover or I manage to drop it before it does so.

06/30/2008 03:14:54 PM changed by jas8522

Perhaps you should do a video screen capture to show this in action... I can't get this to happen no matter what I do...

06/30/2008 03:16:37 PM changed by evands

Robby, have you really updated to [24109] or later? I could reproduce this readily before fixing #10257. I can not reproduce it now.

07/01/2008 12:40:11 AM changed by evands

  • status changed from new to closed.
  • resolution set to worksforme.

Please reopen if you can reproduce this with a current build.

07/01/2008 07:35:17 PM changed by Robby

  • status changed from closed to reopened.
  • resolution deleted.

Yes, that was [24110]. Can't update to latest because of the broken Tiger build just now.
Would a video be helpful to you, Evan?

07/01/2008 07:47:16 PM changed by evands

(Is there a ticket for the build problem?) A video would definitely be helpful. :)

07/01/2008 07:52:40 PM changed by Robby

(The build problem has been thematised in the mailing list.;))
Ok, I'll try to get a video done.

07/01/2008 08:19:25 PM changed by Robby

You can download it here: http://www.mediafire.com/?bmt5mylyxly. :)

07/01/2008 10:34:44 PM changed by jas8522

I just attempted to reproduce this in my 10.4.11 install and I could not... Robbie: wanna try fresh prefs again? I know how much you enjoy doing that :)

07/01/2008 11:09:43 PM changed by jas8522

Oh, in case you haven't done so already, try removing the build directory, then rebuilding Adium... perhaps before the fresh prefs.

07/02/2008 04:41:18 AM changed by Robby

I'm not going to do the fresh prefs, I doubt that will help. I'll try removing the build directory.

07/02/2008 05:13:11 AM changed by Robby

Ok, did that, no change.

07/02/2008 09:02:46 AM changed by Robby

Which preferences files could account for this problem? I certainly don't want set up Adium from scratch.

07/02/2008 11:08:33 AM changed by Robby

Ok, I did do start on a fresh set of preferences after all, to no avail.

07/10/2008 08:01:36 PM changed by Robby

  • priority changed from normal to highest.
  • severity changed from normal to blocker.

07/13/2008 02:13:12 PM changed by evands

What are your sorting settings?

07/13/2008 04:31:13 PM changed by Robby

"Sort contacts by status". More details in the following screenshot.
When I sort my contacts, though, I unhide all contacts and set contact sorting to "manually".

07/13/2008 04:31:50 PM changed by Robby

  • attachment Configure Status Sort.png added.

07/15/2008 07:22:10 PM changed by evands

Does this problem exist in 1.2.7?

07/15/2008 07:31:03 PM changed by Robby

Before I check, let me ask: How could it when in 1.2.7 meta-contacts are not expanded in the contact list?

(follow-up: ↓ 25 ) 07/15/2008 07:55:12 PM changed by evands

Drag & drop to combine contacts has always existed, and drag & drop to reorder has, as well. Also, it isn't clear to me from this ticket that this only happens for you when dragging to a location below a metacontact... is that the case? Dragging works okay if you drop below a non-metacontact?

(in reply to: ↑ 24 ) 07/15/2008 08:39:16 PM changed by Robby

Replying to evands:

Drag & drop to combine contacts has always existed, and drag & drop to reorder has, as well.

I know that, of course. :)

Also, it isn't clear to me from this ticket that this only happens for you when dragging to a location below a metacontact... is that the case? Dragging works okay if you drop below a non-metacontact?

Yes, that is exactly what I mean. I thought I had mentioned that in the original description but perhaps I could have stressed that a little more.

07/18/2008 01:53:29 PM changed by evands

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [24425]) A drop just below a metacontact will appear to be in the group (and should be). In 10.4, however, this incorrectly targets the bottommost index of the metacontact. Adjust to fit reality accordingly. Fixes #10255, finally.

07/23/2008 01:22:39 PM changed by Robby

  • milestone changed from Adium X 1.3 to SVN issues.

Confirmed, thanks a lot, Evan! Great work! :)