Adium

Ticket #10181 (closed crash: fixed)

Opened 4 months ago

Last modified 4 months ago

Crash in oscar_send_im when disconnecting if an action is set to send a message when a user is no longer seen

Reported by: jsailor Assigned to: nobody
Priority: normal Milestone: Adium X 1.3
Component: Adium Core Version: 1.0.6
Severity: normal Keywords:
Cc: Patch: None
Pending: 0

Description

Adium has crashed a number of times in the last few days when I've not been looking at my computer. In every case, the crash is in oscar_send_im, called indirectly as a result of a hostReachabilityChangedCallback.

I don't think I have any events with actions to send an IM, though my AIM account is usually away.

I've got no idea whether what component this bug is in, so I'm leaving it at core for now. I've seen this with 1.3b2 and 1.3b3 and never before 1.3b1, which I never used. (Thankfully, now than #9425 is fixed, it's the only crash I've seen in the 1.3b series! :-) )

Attachments

Adium.crash.log (107.4 kB) - added by jsailor on 06/19/2008 09:55:59 PM.
crash reports
2008-06-19.log (2.5 kB) - added by jsailor on 06/19/2008 10:03:04 PM.
tail of debug log

Change History

06/19/2008 09:55:59 PM changed by jsailor

  • attachment Adium.crash.log added.

crash reports

06/19/2008 10:02:21 PM changed by jsailor

*Just* after submitting this, I discovered that I could also reproduce the crash merely by disconnecting the AIM account; the debug log shows it's a crash caused by a message sent as a result of a "Send a Message" action triggered by a "Contact No Longer Seen" event on one of my contacts.

06/19/2008 10:03:04 PM changed by jsailor

  • attachment 2008-06-19.log added.

tail of debug log

(follow-up: ↓ 3 ) 06/19/2008 10:12:35 PM changed by jas8522

  • milestone set to Adium X 1.3.

(in reply to: ↑ 2 ) 06/19/2008 11:06:04 PM changed by jsailor

Replying to jas8522:

milestone set to Adium X 1.3.

It's worth saying that, while I'd only ever seen this crash with 1.3b, I've almost certainly never tried to send a message to a just-disconnected-from contact as an event action before (and certainly didn't intend to do that this time), and it's a use case should probably be pretty low-priority.

06/24/2008 12:03:58 AM changed by evands

So the event is supposed to be sending a message as soon as a contact goes offline? :P

06/24/2008 12:06:28 AM changed by jas8522

I think he's saying that he went offline, not his contact, then immediately sent a message. But I could be wrong...

06/24/2008 06:56:36 PM changed by evands

(In [24057]) Remove all contacts after noting that we are now offline, not after, so that code responding to this knows that the account is offline. Refs #10181

06/24/2008 06:57:07 PM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [24058]) Only attempt to do the Send Message action if the chat can actually receive the message. Fixes #10181

06/24/2008 07:06:49 PM changed by Robby

Was this in 1.3 only?

06/24/2008 08:03:07 PM changed by evands

  • version changed from 1.3b3 to 1.0.6.
  • summary changed from Crash in oscar_send_im in 1.3b2, 1.3b3 to Crash in oscar_send_im when disconnecting if an action is set to send a message when a user is no longer seen.

No, the description implied it was, but there was nothing new about this crash other than the user not previously setting Adium such that it would happen :)