Adium

Ticket #10152 (closed defect: fixed)

Opened 7 months ago

Last modified 2 days ago

wrong messageclasses on notifications

Reported by: mathuaerknedam Assigned to:
Priority: normal Milestone: Adium 1.3.3
Component: Message View Version: 1.2.5
Severity: regression Keywords:
Cc: Patch: None
Pending: 0

Description

I'm pretty sure this used to be correct, but as of r24008, 1.3b2 and 1.2.5 the messageclasses on incoming notifications (BUZZ!) is incorrect. Incoming is now "libpurplemessage event" and outgoing is "outgoing message notification". The specific messageclasses are different for 1.2.5 because the messageclasses spec were intentionally changes for 1.3, but I've verified with CFM that this wasn't part of the intentional changes.

Change History

06/18/2008 09:44:05 AM changed by jas8522

  • milestone set to Adium X 1.3.2.

Placing a bit later, since this is not a 1.3 regression.

09/02/2008 08:41:47 PM changed by jas8522

  • milestone changed from Adium 1.3.2 to Adium 1.3.3.

10/17/2008 09:13:07 AM changed by Robby

  • severity changed from normal to regression.

12/27/2008 07:47:28 PM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

This was the case for Jabber buzzes only, the result of a libpurple mistake which I fixed in [f94ddf7fa975e3a39a53fccae31b7e73f892fd57] for libpurple 2.5.4.

01/02/2009 10:19:52 AM changed by mathuaerknedam

I thought I had seen this in Yahoo too, but sure enough, Yahoo doesn't get classed with "libpurplemessage". However, Now that I've tested both, I can see another difference in the behaviors between yahoo and jabber. With jabber, the outgoing message is a message and the incoming message is an event. With yahoo, they are both messages. I'd think they should both be events (even though neither one does this currently) or at least be consistent across protocols. Does your libpurple fix address this too?

01/02/2009 05:27:21 PM changed by evands

The fix will make them uniform... we can now consider how best to display the uniform information. I agree that it's more an even than a message... could you please make a ticket for displaying incoming and outgoing buzz-style notifications as events?

01/02/2009 05:41:13 PM changed by mathuaerknedam

Cool. It's #11528.

01/06/2009 05:14:41 PM changed by mathuaerknedam

Evan, think your change might also resolve #11333?