Adium

Ticket #10105 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

Option to overwrite address book images with contacts' icon not working

Reported by: NiKo87 Assigned to: nobody
Priority: normal Milestone: Adium X 1.3
Component: Adium Core Version: 1.3b3
Severity: normal Keywords:
Cc: Patch: None
Pending: 0

Description

Adium is not updating the images in the Address Book, even if the buddy is linked with a contact in my Address Book. I don't know since this features has been broken, but it worked in the past. I have Mac OS X 10.5.3 and I'm using Adium 1.3b2.

Change History

06/14/2008 10:53:52 PM changed by jas8522

  • pending set to 1.
  • milestone set to Needs feedback from users.

Please try 1.3b3 and let us know if this problem continues for you. Also ensure that you attempt to re-link them with a contact in the address book, just in case the link was lost or something similar.

06/15/2008 09:24:51 AM changed by NiKo87

  • pending deleted.

I've updated to 1.3b3 and relinked the buddies but it doesn't solve the problem. If I click on the buddy and click on "Show in the Address Book" it opens the correct contact, but with a wrong image of course :P

06/15/2008 05:41:05 PM changed by jas8522

  • summary changed from Adium is not updating the images in the Address Book to Option to overwrite address book images with contacts' icon not working.
  • version changed from 1.3b2 to 1.3b3.
  • milestone changed from Needs feedback from users to Adium X 1.3.

I was assuming from the start that you have the preference to do this checked, correct?

06/16/2008 02:45:09 AM changed by NiKo87

You're right, the option is checked.

06/24/2008 07:56:34 PM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [24067]) KEY_USER_ICON is a display attribute; it is no longer coincidentally posted as a status update, so we automatic syncing to address book was broken. Now it's used properly. Fixes #10105

06/24/2008 07:59:47 PM changed by jas8522

  • milestone changed from Adium X 1.3 to SVN issues.

Going on the assumption that this was new to the beta, although NiKo87 was unsure of when it started being a problem.

06/24/2008 08:03:37 PM changed by evands

I broke it with my complete rewrite of the user icon system for 1.3. New to the beta :)

06/25/2008 05:23:48 AM changed by NiKo87

I've just compiled the latest SVN and now Adium is extremely slow in updating my MSN contact's images and it still doesn't update the Address Book. I've even relinked the contacts.

06/25/2008 06:57:42 AM changed by evands

  • status changed from closed to reopened.
  • resolution deleted.

What do you mean by extremely slow?

06/25/2008 06:57:50 AM changed by evands

  • milestone changed from SVN issues to Adium X 1.3.

06/25/2008 06:59:37 AM changed by NiKo87

I've been online for 4 hours and it updated only 5 contacts on 50 and more.

06/25/2008 07:01:07 AM changed by evands

Okay. Please create new tickets for new issues rather than changing topics within existing tickets.

06/25/2008 07:04:41 AM changed by NiKo87

Ok, sorry, I'll post a new ticket as soon as I have more data on the issue.

06/25/2008 08:26:22 AM changed by Robby

  • status changed from reopened to closed.
  • resolution set to fixed.
  • milestone changed from Adium X 1.3 to SVN issues.

06/25/2008 10:54:21 AM changed by NiKo87

Sorry, but I don't think that this is fixed right now.

06/25/2008 11:06:13 AM changed by Robby

Didn't you say you wanted to file a new ticket?

06/25/2008 11:11:59 AM changed by NiKo87

Yes, but for another issue regarding the contacts' images. The issue of this ticket has not been fixed yet.

06/25/2008 11:15:36 AM changed by Robby

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone changed from SVN issues to Adium X 1.3.

Ok, right. Sorry for the spam.

06/28/2008 09:51:00 AM changed by evands

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [24080]) Fixed a bunch of stupidity I did a long time ago in ESAddressBookIntegrationPlugin related to automatic contact image syncing, including the following cute snippet: 

if (!existingABImage ||
	(objectUserIcon && [(objectUserIconData = [objectUserIcon PNGRepresentation]) isEqualToData:[existingABImage PNGRepresentation]])) {
	[person setImageData:objectUserIconData];
}

which says, "If the person doesn't currently have an image, or the existing image is the same as the new one, set the new one." It also would never set objectUserIconData if there were no existing image. This meant syncing worked in no cases.

That's all fixed now. Fixes #10105