Adium

Ticket #10102 (closed defect: fixed)

Opened 6 months ago

Last modified 5 months ago

/me command displays improper formatting

Reported by: mdeatherage Assigned to: catfish_man
Priority: normal Milestone: SVN issues
Component: Message View Version: 1.3b2
Severity: regression Keywords: /me
Cc: Patch: None
Pending: 0

Description

When issuing the /me command on 1.2.5, you get back something like this:

"/me eats pudding" -> "*MyNick eats pudding*"

The same command on 1.3b1 and 1.3b2 generates:

"/me eats pudding" -> "MyNickeats pudding"

The lack of stars or other visual indication of an action is a stylistic thing, but there at least needs to be a space after the nickname in the output. This happens for me on both PPC and Intel, on AIM and Yahoo (don't have other accounts to test).

Change History

06/13/2008 05:09:34 PM changed by evands

  • severity changed from normal to regression.
  • milestone set to Adium X 1.3.

What message style are you using in which you're seeing this? /me formatting is now message style dependent, which is great for message styles that know what to do... but we need to have some sane fallback behavior for others.

06/13/2008 05:11:01 PM changed by evands

  • owner set to catfish_man.

06/13/2008 05:56:15 PM changed by Catfish_Man

If the message style provides its own Template.html there's very little I can do. If it doesn't, it should display as it did in 1.2.x by default.

06/13/2008 06:36:17 PM changed by evands

Could we use the versionining capability of message styles? Old versions with custom Template.html files would get the old *XXX* style, new versions and all versions using our default Template.html get proper handling?

06/13/2008 06:55:00 PM changed by Catfish_Man

Yeah... we could do that. I'm all hacked out right now and running on 4.5 hours of sleep, but when I recuperate I'll look into it.

06/14/2008 02:46:54 PM changed by evands

(In [23974])

  • Define a Version 4 message style version, which has the replaceLastMessage() in its template.html. David, I think you wanted to make use of a new version, as well - this is just a tentative set of changes for version 4. Refs #10102 for the versioning.
  • Fix Version 3 message styles with custom Template.html files in terms of display of status messages which should coalesce. They can't, because there is no replaceLastMessage() in that Template version. We only attempt to coalesce now if there is no custom template or if the version >= 4. Refs #10015 (where cheesy reported the problem with Fiat.

07/17/2008 06:47:04 PM changed by evands

  • status changed from new to closed.
  • resolution set to fixed.

(In [24412]) Made support for HTML filters (including the /me replacement) part of style version 4. Fixes #10102

07/17/2008 06:47:28 PM changed by evands

  • milestone changed from Adium X 1.3 to SVN issues.