Adium

Ticket #10086 (closed patch: fixed)

Opened 3 months ago

Last modified 2 months ago

Chat transcript viewer doesn't display italics

Reported by: zacw Assigned to: nobody
Priority: normal Milestone: Adium X 1.3
Component: Adium UI Version: 1.3svn
Severity: normal Keywords:
Cc: Patch: Accepted
Pending: 0

Description

The chat transcript viewer will display bold and underline, but text formatted with italics does not display regardless of the font used. This is not a regression, but it is annoying.

Attachments

DecodeItalics(#10086).diff (72.1 kB) - added by jeremyw.sherman on 06/19/2008 01:56:40 PM.
Patch AIHTMLDecoder.m to handle font-style in the style attribute of a span element.

Change History

06/19/2008 01:56:40 PM changed by jeremyw.sherman

  • attachment DecodeItalics(#10086).diff added.

Patch AIHTMLDecoder.m to handle font-style in the style attribute of a span element.

06/19/2008 02:07:00 PM changed by zacw

  • patch_status changed from None to Needs Dev Review.
  • type changed from defect to patch.

06/19/2008 02:14:05 PM changed by jeremyw.sherman

Verified bug appears in both log viewer and recent message context. XML log files correctly encode italics. Tracked problem to -processSpanTagArgs:attributes: in AIHTMLDecoder.m. There, the method handled font-weight: but not font-style: .

It sufficed to mimic how font-weight: was handled. I have verified this resolves the bug for messages displayed in both the log viewer and recent message context. A patch is attached.

(The patch file includes a lot of noise about changes Xcode must have made to .xcodeproj. Should I be editing that out of the svn-generated diff prior to attaching it here? I also didn't see any patch checkbox to check.)

06/19/2008 02:19:50 PM changed by zacw

You can diff certain files by using svn diff <file1> <file2> <...>. I've set the patch flag, and I'll probably take a look at the patch later today (simple enough that it's probably valid anyway, since it's very nearly exactly font-weight).

06/19/2008 05:53:01 PM changed by zacw

  • status changed from new to closed.
  • resolution set to fixed.

(In [24020]) Patch from jeremyw.sherman to add italics to the HTML decoder. Fixes #10086.

07/12/2008 07:13:12 AM changed by Robby

  • patch_status changed from Needs Dev Review to Accepted.