Adium

Changeset 24420

Show
Ignore:
Timestamp:
07/18/2008 09:41:32 AM (5 months ago)
Author:
evands
Message:

Fixed a 'dead store' static analysis warning which was actually a significant bug: we were repeatedly checking the metacontact within a loop through its contacts rather than checking its contact. This should fix some unusual cases in which an address book icon improperly overrode a serverside icon.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/Source/AIAddressBookUserIconSource.m

    r23955 r24420  
    7272                AIListContact *listContact; 
    7373                while ((listContact = [enumerator nextObject])) { 
    74                         if (![AIUserIcons userIconSource:self changeWouldBeRelevantForObject:inObject]) 
     74                        if (![AIUserIcons userIconSource:self changeWouldBeRelevantForObject:listContact]) 
    7575                                return AIUserIconSourceDidNotFindIcon; 
    7676                }