Changeset 24079

Timestamp:

06/28/2008 12:46:23 AM (6 months ago)

Author:

evands

Message:

Removed an optimization which has been in place forever and just causes weird behavior. There's no reason to attempt to lump together notifications for attribute changes; at the cost of a few extra redraws of specific rows of the contact list, we lose the ability to reliably respond to changes. This fix is key to address book syncing working properly, among other things.

Files:

• trunk/Source/AdiumContactPropertiesObserverManager.m (modified) (2 diffs)

trunk/Source/AdiumContactPropertiesObserverManager.m

@@ -162 +162 @@
-                        [[adium contactController] sortListObject:inObject];
-        }
-       
-
-       [[adium notificationCenter] postNotificationName:ListObject_AttributesChanged
-                                                                                         object:inObject
-       userInfo:(inModifiedKeys ?
-                         [NSDictionary dictionaryWithObject:inModifiedKeys
-                                                                 forKey:@"Keys"] :
-  nil)];
-}
+}
+
+//Post an attributes changed message
+[[adium notificationCenter] postNotificationName:ListObject_AttributesChanged
+  object:inObject
+userInfo:(inModifiedKeys ?
+  [NSDictionary dictionaryWithObject:inModifiedKeys
+                                                 forKey:@"Keys"] :
+                                                                                                 nil)];        
-}
-
@@ -200 +200 @@
-                                shouldSort = YES;
-                        }
-                        [[adium notificationCenter] postNotificationName:ListObject_AttributesChanged
-                                                                                                          object:nil
-                                                                                                        userInfo:(delayedModifiedAttributeKeys ?
-                                                                                                                          [NSDictionary dictionaryWithObject:delayedModifiedAttributeKeys
-                                                                                                                                                                                  forKey:@"Keys"] :
-                                                                                                                          nil)];
-                        [delayedModifiedAttributeKeys removeAllObjects];
-                        delayedAttributeChanges = 0;